Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 378193002: AppWindowContents: Clean up unnecessary SuspendRenderViewHost. (Closed)

Created:
6 years, 5 months ago by Matt Giuca
Modified:
6 years, 5 months ago
CC:
chromium-reviews, tfarina, chromium-apps-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org, Jeffrey Yasskin, scheib
Project:
chromium
Visibility:
Public.

Description

AppWindowContents: Clean up unnecessary SuspendRenderViewHost. This is no longer necessary since crbug.com/123007 was fixed. BUG=123007 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284866

Patch Set 1 #

Patch Set 2 : LoadContents doesn't need a creator_process_id. #

Patch Set 3 : Remove unused includes. #

Patch Set 4 : Remove more unused includes. #

Patch Set 5 : Remove even more unused includes. #

Total comments: 9

Patch Set 6 : Small nits. #

Patch Set 7 : Revert initial suspension of resource requests on app window open. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -46 lines) Patch
M apps/app_window_contents.h View 1 2 3 4 5 6 4 chunks +1 line, -11 lines 0 comments Download
M apps/app_window_contents.cc View 1 2 3 4 5 6 4 chunks +1 line, -35 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
Matt Giuca
creis: Did the groundwork for this CL. kalman: OWNERS. Hey guys, so full disclosure: I ...
6 years, 5 months ago (2014-07-09 05:46:38 UTC) #1
not at google - send to devlin
+nasko Nice cleanup, lgtm for extensions but I'm not confident to suggest you submit this ...
6 years, 5 months ago (2014-07-09 13:48:51 UTC) #2
not at google - send to devlin
https://codereview.chromium.org/378193002/diff/80001/apps/app_window_contents.cc File apps/app_window_contents.cc (left): https://codereview.chromium.org/378193002/diff/80001/apps/app_window_contents.cc#oldcode49 apps/app_window_contents.cc:49: // RVH from loading anything until the background page ...
6 years, 5 months ago (2014-07-09 13:51:31 UTC) #3
scheib
https://codereview.chromium.org/378193002/diff/80001/apps/app_window_contents.cc File apps/app_window_contents.cc (left): https://codereview.chromium.org/378193002/diff/80001/apps/app_window_contents.cc#oldcode49 apps/app_window_contents.cc:49: // RVH from loading anything until the background page ...
6 years, 5 months ago (2014-07-09 17:31:56 UTC) #4
Matt Giuca
https://codereview.chromium.org/378193002/diff/80001/apps/app_window_contents.cc File apps/app_window_contents.cc (left): https://codereview.chromium.org/378193002/diff/80001/apps/app_window_contents.cc#oldcode49 apps/app_window_contents.cc:49: // RVH from loading anything until the background page ...
6 years, 5 months ago (2014-07-10 03:37:07 UTC) #5
scheib
https://codereview.chromium.org/378193002/diff/80001/chrome/browser/extensions/api/app_window/app_window_api.cc File chrome/browser/extensions/api/app_window/app_window_api.cc (right): https://codereview.chromium.org/378193002/diff/80001/chrome/browser/extensions/api/app_window/app_window_api.cc#newcode293 chrome/browser/extensions/api/app_window/app_window_api.cc:293: created_view->GetProcess()->GetID()) On 2014/07/10 03:37:06, Matt Giuca wrote: > I'm ...
6 years, 5 months ago (2014-07-10 16:53:11 UTC) #6
not at google - send to devlin
https://codereview.chromium.org/378193002/diff/80001/chrome/browser/extensions/api/app_window/app_window_api.cc File chrome/browser/extensions/api/app_window/app_window_api.cc (right): https://codereview.chromium.org/378193002/diff/80001/chrome/browser/extensions/api/app_window/app_window_api.cc#newcode293 chrome/browser/extensions/api/app_window/app_window_api.cc:293: created_view->GetProcess()->GetID()) On 2014/07/10 16:53:11, scheib wrote: > On 2014/07/10 ...
6 years, 5 months ago (2014-07-10 17:03:10 UTC) #7
Matt Giuca
nasko: Friendly ping. (creis is OOO for awhile so hopefully you can look at this.) ...
6 years, 5 months ago (2014-07-11 00:15:49 UTC) #8
Matt Giuca
Ping: Nasko, would you be able to look at this?
6 years, 5 months ago (2014-07-16 00:31:39 UTC) #9
nasko
I was out for a few days myself, so apologies for the delays. Since I'm ...
6 years, 5 months ago (2014-07-16 14:45:48 UTC) #10
Matt Giuca
Hmm, I had a look over this again in trying to explain it. I think ...
6 years, 5 months ago (2014-07-17 03:56:35 UTC) #11
nasko
On 2014/07/17 03:56:35, Matt Giuca wrote: > Hmm, I had a look over this again ...
6 years, 5 months ago (2014-07-17 14:00:52 UTC) #12
Matt Giuca
> The current change looks fine to me, but I'm not sure if I'm missing ...
6 years, 5 months ago (2014-07-21 00:33:19 UTC) #13
Charlie Reis
On 2014/07/21 00:33:19, Matt Giuca wrote: > > The current change looks fine to me, ...
6 years, 5 months ago (2014-07-22 19:59:54 UTC) #14
Charlie Reis
Ok, patch set 7 (which just removes the NotificationObserver) LGTM. I can confirm that we ...
6 years, 5 months ago (2014-07-22 20:30:05 UTC) #15
Matt Giuca
The CQ bit was checked by mgiuca@chromium.org
6 years, 5 months ago (2014-07-23 00:21:56 UTC) #16
Matt Giuca
Thanks, Charlie! > Ok, patch set 7 (which just removes the NotificationObserver) LGTM. I can ...
6 years, 5 months ago (2014-07-23 00:22:34 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/378193002/120001
6 years, 5 months ago (2014-07-23 00:23:31 UTC) #18
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-23 03:19:28 UTC) #19
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 06:37:32 UTC) #20
Message was sent while issue was closed.
Change committed as 284866

Powered by Google App Engine
This is Rietveld 408576698