AppWindowContents: Clean up unnecessary SuspendRenderViewHost.

chrome/browser/extensions/api/app_window/app_window_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/app_window/app_window_api.h"
 
 #include "apps/app_window.h"
 #include "apps/app_window_contents.h"
 #include "apps/app_window_registry.h"
 #include "apps/apps_client.h"
@@ skipping 260 matching lines @@
         case extensions::api::app_window::STATE_MAXIMIZED:
           create_params.state = ui::SHOW_STATE_MAXIMIZED;
           break;
         case extensions::api::app_window::STATE_MINIMIZED:
           create_params.state = ui::SHOW_STATE_MINIMIZED;
           break;
       }
     }
   }
 
-  create_params.creator_process_id =
-      render_view_host_->GetProcess()->GetID();
-
   AppWindow* app_window = apps::AppsClient::Get()->CreateAppWindow(
       browser_context(), GetExtension());
   app_window->Init(
       url, new apps::AppWindowContentsImpl(app_window), create_params);
 
   if (ExtensionsBrowserClient::Get()->IsRunningInForcedAppMode())
     app_window->ForcedFullscreen();
 
   content::RenderViewHost* created_view =
       app_window->web_contents()->GetRenderViewHost();
   int view_id = MSG_ROUTING_NONE;
-  if (create_params.creator_process_id == created_view->GetProcess()->GetID())
+  if (render_view_host_->GetProcess()->GetID() ==
+      created_view->GetProcess()->GetID())

[not at google - send to devlin, 2014/07/09 13:48:50]

nit: body should have {} since condition is 2 lines.

not-nit: relating to previous comment, seems like this should be a DCHECK_EQ not
an if.

btw this is the same check as up on line 199, maybe that should be the same.

[Matt Giuca, 2014/07/10 03:37:06]

I'm not sure about the DCHECK vs if. I'll leave it up to the other reviewers to
decide.

[scheib, 2014/07/10 16:53:11]

An if or a CHECK I think --- if we just use a DCHECK then non equal IDs will
change the routing, which could be a security issue, for non-trivial to
understand code.  I favor the CHECK, see if it works, in which case we'll have
more certainty of the code behavior.

[not at google - send to devlin, 2014/07/10 17:03:10]

yeah, I think an if is fine.

[Matt Giuca, 2014/07/11 00:15:49]

So I'll leave this as-is.

     view_id = created_view->GetRoutingID();
 
   base::DictionaryValue* result = new base::DictionaryValue;
   result->Set("viewId", new base::FundamentalValue(view_id));
   result->Set("injectTitlebar",
       new base::FundamentalValue(inject_html_titlebar_));
   result->Set("id", new base::StringValue(app_window->window_key()));
   app_window->GetSerializedState(result);
   SetResult(result);
 
@@ skipping 184 matching lines @@
 
   if (options.frame->as_frame_options->inactive_color.get()) {
     error_ = app_window_constants::kInactiveColorWithoutColor;
     return false;
   }
 
   return true;
 }
 
 }  // namespace extensions