MacViews: Consolidate kBrowserActionContainerWidth pref registration

MacViews: Consolidate kBrowserActionContainerWidth pref registration

This pref is currently registered in different places for Mac and
toolkit-views, resulting in problems for toolkit-views on Mac (i.e. it
gets registered twice).

The views pref moved into extension_prefs.cc in r183799. This moves the
mac pref to the same place for increased code cohesion, simplifying a
lot of things.

BUG=155525, 390755
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282177

[tapted, 2014-07-09 04:14:34]

Hello, please take a look:
rsesek: c/b/ui/cocoa 
bauerb: c/b/prefs/ 
devlin: extensions

Thanks!

[Bernhard Bauer, 2014-07-09 08:16:15]

lgtm

https://codereview.chromium.org/378153002/diff/1/extensions/browser/extension...
File extensions/browser/extension_prefs.cc (right):

https://codereview.chromium.org/378153002/diff/1/extensions/browser/extension...
extensions/browser/extension_prefs.cc:1980: #else
I find it a bit weird that the same pref will have different types on different
platforms, but that's maybe not something for this CL to fix.

[tapted, 2014-07-09 11:21:53]

oops -rsesek is OOO. +groby - PTAL for OWNERS in chrome/browser/ui/cocoa

https://codereview.chromium.org/378153002/diff/1/extensions/browser/extension...
File extensions/browser/extension_prefs.cc (right):

https://codereview.chromium.org/378153002/diff/1/extensions/browser/extension...
extensions/browser/extension_prefs.cc:1980: #else
On 2014/07/09 08:16:15, Bernhard Bauer wrote:
> I find it a bit weird that the same pref will have different types on
different
> platforms, but that's maybe not something for this CL to fix.

The rationale is likely to be that Cocoa uses floating point for positioning
NSViews, whereas toolkit-views is integer-based. It's probably harmless to
switch to int.. But I'll revisit this in the somewhat distant future when the
toolbar is ported to views for Mac. I guess there's also a remote possibility
toolkit-views switches to float for better touch/hidpi support..

[Devlin, 2014-07-09 15:32:03]

extensions lgtm

[groby-ooo-7-16, 2014-07-09 21:16:20]

cocoa LGTM

[tapted, 2014-07-09 22:49:22]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2014-07-09 22:50:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tapted@chromium.org/378153002/1

[commit-bot: I haz the power, 2014-07-09 23:42:08]

Change committed as 282177