MacViews: Consolidate kBrowserActionContainerWidth pref registration

extensions/browser/extension_prefs.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/extension_prefs.h"
 
 #include <iterator>
 
 #include "base/command_line.h"
 #include "base/prefs/pref_notifier.h"
@@ skipping 1954 matching lines @@
       0,  // default value
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
   registry->RegisterListPref(pref_names::kAllowedInstallSites,
                              user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
   registry->RegisterStringPref(
       pref_names::kLastChromeVersion,
       std::string(),  // default value
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
   registry->RegisterListPref(pref_names::kKnownDisabled,
                              user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
-#if defined(TOOLKIT_VIEWS)
+#if defined(OS_MACOSX)
+  registry->RegisterDoublePref(
+      pref_names::kBrowserActionContainerWidth,
+      0,
+      user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
+#else

[Bernhard Bauer, 2014/07/09 08:16:15]

I find it a bit weird that the same pref will have different types on different
platforms, but that's maybe not something for this CL to fix.

[tapted, 2014/07/09 11:21:53]

The rationale is likely to be that Cocoa uses floating point for positioning
NSViews, whereas toolkit-views is integer-based. It's probably harmless to
switch to int.. But I'll revisit this in the somewhat distant future when the
toolbar is ported to views for Mac. I guess there's also a remote possibility
toolkit-views switches to float for better touch/hidpi support..

   registry->RegisterIntegerPref(
       pref_names::kBrowserActionContainerWidth,
       0,
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
 #endif
   registry->RegisterDictionaryPref(
       kInstallSignature,
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
 
   registry->RegisterListPref(pref_names::kNativeMessagingBlacklist,
@@ skipping 194 matching lines @@
   extension_pref_value_map_->RegisterExtension(
       extension_id, install_time, is_enabled, is_incognito_enabled);
 
   FOR_EACH_OBSERVER(
       ExtensionPrefsObserver,
       observer_list_,
       OnExtensionRegistered(extension_id, install_time, is_enabled));
 }
 
 }  // namespace extensions