MacViews: Consolidate kBrowserActionContainerWidth pref registration

extensions/browser/extension_prefs.cc

Index: extensions/browser/extension_prefs.cc
diff --git a/extensions/browser/extension_prefs.cc b/extensions/browser/extension_prefs.cc
index 030cedae26d1866c9291431b751bbb8f508d1713..7799f0d04dde7d06fae7238dd78a9b00f5a59883 100644
--- a/extensions/browser/extension_prefs.cc
+++ b/extensions/browser/extension_prefs.cc
@@ -1972,7 +1972,12 @@ void ExtensionPrefs::RegisterProfilePrefs(
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
   registry->RegisterListPref(pref_names::kKnownDisabled,
                              user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
-#if defined(TOOLKIT_VIEWS)
+#if defined(OS_MACOSX)
+  registry->RegisterDoublePref(
+      pref_names::kBrowserActionContainerWidth,
+      0,
+      user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
+#else

[Bernhard Bauer, 2014/07/09 08:16:15]

I find it a bit weird that the same pref will have different types on different
platforms, but that's maybe not something for this CL to fix.

[tapted, 2014/07/09 11:21:53]

The rationale is likely to be that Cocoa uses floating point for positioning
NSViews, whereas toolkit-views is integer-based. It's probably harmless to
switch to int.. But I'll revisit this in the somewhat distant future when the
toolbar is ported to views for Mac. I guess there's also a remote possibility
toolkit-views switches to float for better touch/hidpi support..

   registry->RegisterIntegerPref(
       pref_names::kBrowserActionContainerWidth,
       0,