Move GraphicsTypes* and ColorSpace to Source/platform

Move GraphicsTypes* and ColorSpace to Source/platform

BUG=297477
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160494

[rwlbuis, 2013-10-23 21:32:13]

Move some useful graphics files. This is probably useful to get out of the way
before moving the more complicated stuff like GraphicsContext.h and
ImageBuffer.h

[abarth-chromium, 2013-10-24 14:13:11]

LGTM w/ comments beloe.

https://codereview.chromium.org/37803003/diff/1/Source/core/platform/graphics...
File Source/core/platform/graphics/StrokeData.h (right):

https://codereview.chromium.org/37803003/diff/1/Source/core/platform/graphics...
Source/core/platform/graphics/StrokeData.h:37: 
There's no need for these blank lines.  Please put all these headers together in
one block and sort them.

https://codereview.chromium.org/37803003/diff/1/Source/core/platform/graphics...
File Source/core/platform/graphics/filters/custom/CustomFilterProgramInfo.h
(right):

https://codereview.chromium.org/37803003/diff/1/Source/core/platform/graphics...
Source/core/platform/graphics/filters/custom/CustomFilterProgramInfo.h:35: 
ditto

https://codereview.chromium.org/37803003/diff/1/Source/core/rendering/svg/SVG...
File Source/core/rendering/svg/SVGRenderTreeAsText.cpp (right):

https://codereview.chromium.org/37803003/diff/1/Source/core/rendering/svg/SVG...
Source/core/rendering/svg/SVGRenderTreeAsText.cpp:68: 
ditto

https://codereview.chromium.org/37803003/diff/1/Source/platform/graphics/Colo...
File Source/platform/graphics/ColorSpace.h (right):

https://codereview.chromium.org/37803003/diff/1/Source/platform/graphics/Colo...
Source/platform/graphics/ColorSpace.h:33: 
There's no need to export enums.  There's nothing to export.

https://codereview.chromium.org/37803003/diff/1/Source/platform/graphics/Grap...
File Source/platform/graphics/GraphicsTypes.h (left):

https://codereview.chromium.org/37803003/diff/1/Source/platform/graphics/Grap...
Source/platform/graphics/GraphicsTypes.h:31: 
Please put these headers all together in one block and sort.

https://codereview.chromium.org/37803003/diff/1/Source/platform/graphics/Grap...
File Source/platform/graphics/GraphicsTypes.h (right):

https://codereview.chromium.org/37803003/diff/1/Source/platform/graphics/Grap...
Source/platform/graphics/GraphicsTypes.h:37: 
There's no reason to export enums.  The reason to export something is to make
the symbol available outside the DLL.  There are no symbols associated with
enums.  They're just constants.

https://codereview.chromium.org/37803003/diff/1/Source/platform/graphics/Grap...
Source/platform/graphics/GraphicsTypes.h:129: 
These functions do make sense to export because they're symbols that are
implemented in the CPP file.  When someone outside the DLL wants to call these
functions, they need to be able to find the implementation inside the DLL.

[rwlbuis, 2013-10-24 14:30:19]

On 2013/10/24 14:13:11, abarth wrote:
> LGTM w/ comments beloe.

Thanks, will fix.
What you said about the enum thing makes sense, I wasn't so sure either. I was
just mislead by such existing constructions as
Source/platform/CalculationValue.h :)

[abarth-chromium, 2013-10-24 14:39:57]

On 2013/10/24 14:30:19, rwlbuis wrote:
> What you said about the enum thing makes sense, I wasn't so sure either. I was
> just mislead by such existing constructions as
> Source/platform/CalculationValue.h :)

Would you be willing to post a separate CL to fix CalculationValue.h?  In
addition to the extra enum exports, that file also tries to export an inline
function at the bottom, which is also unnecessary.

[Stephen Chennney, 2013-10-24 15:02:07]

On 2013/10/24 14:39:57, abarth wrote:
> On 2013/10/24 14:30:19, rwlbuis wrote:
> > What you said about the enum thing makes sense, I wasn't so sure either. I
was
> > just mislead by such existing constructions as
> > Source/platform/CalculationValue.h :)
> 
> Would you be willing to post a separate CL to fix CalculationValue.h?  In
> addition to the extra enum exports, that file also tries to export an inline
> function at the bottom, which is also unnecessary.

I'll fix CalculationValue, as I broke it. I think there might be other cases (I
also searched the code for examples) and I'll fix those too.

[abarth-chromium, 2013-10-24 15:19:45]

Thanks!

[rwlbuis, 2013-10-24 17:04:49]

Comments should be addressed to now.

https://codereview.chromium.org/37803003/diff/1/Source/core/platform/graphics...
File Source/core/platform/graphics/StrokeData.h (right):

https://codereview.chromium.org/37803003/diff/1/Source/core/platform/graphics...
Source/core/platform/graphics/StrokeData.h:37: 
On 2013/10/24 14:13:12, abarth wrote:
> There's no need for these blank lines.  Please put all these headers together
in
> one block and sort them.

Done.

https://codereview.chromium.org/37803003/diff/1/Source/core/platform/graphics...
File Source/core/platform/graphics/filters/custom/CustomFilterProgramInfo.h
(right):

https://codereview.chromium.org/37803003/diff/1/Source/core/platform/graphics...
Source/core/platform/graphics/filters/custom/CustomFilterProgramInfo.h:35: 
On 2013/10/24 14:13:12, abarth wrote:
> ditto

Done.

https://codereview.chromium.org/37803003/diff/1/Source/core/rendering/svg/SVG...
File Source/core/rendering/svg/SVGRenderTreeAsText.cpp (right):

https://codereview.chromium.org/37803003/diff/1/Source/core/rendering/svg/SVG...
Source/core/rendering/svg/SVGRenderTreeAsText.cpp:68: 
On 2013/10/24 14:13:12, abarth wrote:
> ditto

Done.

https://codereview.chromium.org/37803003/diff/1/Source/platform/graphics/Colo...
File Source/platform/graphics/ColorSpace.h (right):

https://codereview.chromium.org/37803003/diff/1/Source/platform/graphics/Colo...
Source/platform/graphics/ColorSpace.h:33: 
On 2013/10/24 14:13:12, abarth wrote:
> There's no need to export enums.  There's nothing to export.

Done.

https://codereview.chromium.org/37803003/diff/1/Source/platform/graphics/Grap...
File Source/platform/graphics/GraphicsTypes.h (left):

https://codereview.chromium.org/37803003/diff/1/Source/platform/graphics/Grap...
Source/platform/graphics/GraphicsTypes.h:31: 
On 2013/10/24 14:13:12, abarth wrote:
> Please put these headers all together in one block and sort.

Done.

https://codereview.chromium.org/37803003/diff/1/Source/platform/graphics/Grap...
File Source/platform/graphics/GraphicsTypes.h (right):

https://codereview.chromium.org/37803003/diff/1/Source/platform/graphics/Grap...
Source/platform/graphics/GraphicsTypes.h:37: 
On 2013/10/24 14:13:12, abarth wrote:
> There's no reason to export enums.  The reason to export something is to make
> the symbol available outside the DLL.  There are no symbols associated with
> enums.  They're just constants.

Done.

https://codereview.chromium.org/37803003/diff/1/Source/platform/graphics/Grap...
Source/platform/graphics/GraphicsTypes.h:129: 
On 2013/10/24 14:13:12, abarth wrote:
> These functions do make sense to export because they're symbols that are
> implemented in the CPP file.  When someone outside the DLL wants to call these
> functions, they need to be able to find the implementation inside the DLL.

Done.

[commit-bot: I haz the power, 2013-10-24 18:53:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/37803003/140001

[commit-bot: I haz the power, 2013-10-24 19:29:55]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac_layout.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-10-24 19:41:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/37803003/310001

[commit-bot: I haz the power, 2013-10-24 20:57:38]

Change committed as 160494