Rename about:labs to about:flags, part 3/3

Rename about:labs to about:flags, part 3/3

This renames the cc and h files, and renames the --no-labs switch to --no-experiments

BUG=59139
TEST=about:flags still works

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62682

[viettrungluu, 2010-10-14 23:28:48]

Rubberstamp LGTM with browser/flags.* -> browser/about_flags.* and namespace
flags -> namespace about_flags (and maybe --no-flags -> --give-trungl-a-pony).

http://codereview.chromium.org/3777005/diff/2001/3001
File chrome/browser/browser_about_handler.cc (right):

http://codereview.chromium.org/3777005/diff/2001/3001#newcode32
chrome/browser/browser_about_handler.cc:32: #include "chrome/browser/flags.h"
"flags" sounds really generic.

http://codereview.chromium.org/3777005/diff/2001/3003
File chrome/browser/dom_ui/dom_ui_factory.cc (right):

http://codereview.chromium.org/3777005/diff/2001/3003#newcode130
chrome/browser/dom_ui/dom_ui_factory.cc:130: return &NewDOMUI<HistoryUI2>;
Maybe calling the namespace "about_flags" (and the files about_flags*) would be
better?

http://codereview.chromium.org/3777005/diff/2001/3010
File chrome/browser/resources/flags.html (right):

http://codereview.chromium.org/3777005/diff/2001/3010#newcode199
chrome/browser/resources/flags.html:199: * Asks the C++ FlagsDOMHandler to get
details about the available experiments
I'm glad you didn't forget.

http://codereview.chromium.org/3777005/diff/2001/3012
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/3777005/diff/2001/3012#newcode774
chrome/common/chrome_switches.cc:774: const char kNoFlags[]                     
  = "no-flags";
Maybe "no-about-flags"? (And kNoAboutFlags?)

[Nico, 2010-10-14 23:31:34]

http://codereview.chromium.org/3777005/diff/2001/3003
File chrome/browser/dom_ui/dom_ui_factory.cc (right):

http://codereview.chromium.org/3777005/diff/2001/3003#newcode130
chrome/browser/dom_ui/dom_ui_factory.cc:130: return &NewDOMUI<HistoryUI2>;
On 2010/10/14 23:28:49, viettrungluu wrote:
> Maybe calling the namespace "about_flags" (and the files about_flags*) would
be
> better?

Yes. Done.

http://codereview.chromium.org/3777005/diff/2001/3012
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/3777005/diff/2001/3012#newcode774
chrome/common/chrome_switches.cc:774: const char kNoFlags[]                     
  = "no-flags";
On 2010/10/14 23:28:49, viettrungluu wrote:
> Maybe "no-about-flags"? (And kNoAboutFlags?)

Maybe --no-experiments? (The table on about:flags has "Experiments" as heading)

[viettrungluu, 2010-10-14 23:34:05]

On 2010/10/14 23:31:34, Nico wrote:
> Maybe --no-experiments? (The table on about:flags has "Experiments" as
heading)

SGTM.

[Nico, 2010-10-14 23:39:48]

On 2010/10/14 23:34:05, viettrungluu wrote:
> On 2010/10/14 23:31:34, Nico wrote:
> > Maybe --no-experiments? (The table on about:flags has "Experiments" as
> heading)
> 
> SGTM.

Done as well.