Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: chrome/browser/about_flags.h

Issue 3777005: Rename about:labs to about:flags, part 3/3 (Closed)
Patch Set: comments Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/about_flags.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.h
diff --git a/chrome/browser/labs.h b/chrome/browser/about_flags.h
similarity index 54%
rename from chrome/browser/labs.h
rename to chrome/browser/about_flags.h
index 7a13b1b2f66d89d4f0c769c68e9eaa0264bd3bd3..fd6d8e451a2244930c5d14c717f6d8edc08deac3 100644
--- a/chrome/browser/labs.h
+++ b/chrome/browser/about_flags.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_LABS_H_
-#define CHROME_BROWSER_LABS_H_
+#ifndef CHROME_BROWSER_ABOUT_FLAGS_H_
+#define CHROME_BROWSER_ABOUT_FLAGS_H_
#pragma once
#include <string>
@@ -12,18 +12,17 @@ class CommandLine;
class ListValue;
class PrefService;
-// Can't be called "labs", that collides with the C function |labs()|.
-namespace about_labs {
+namespace about_flags {
-// Returns if Labs is enabled (it isn't on the stable channel).
+// Returns if Flags is enabled (it isn't for ChromeOS at the moment).
bool IsEnabled();
-// Reads the Labs |prefs| and adds the commandline flags belonging
-// to the active experiments to |command_line|.
-void ConvertLabsToSwitches(PrefService* prefs, CommandLine* command_line);
+// Reads the Labs |prefs| (called "Labs" for historical reasons) and adds the
+// commandline flags belonging to the active experiments to |command_line|.
+void ConvertFlagsToSwitches(PrefService* prefs, CommandLine* command_line);
// Get a list of all available experiments. The caller owns the result.
-ListValue* GetLabsExperimentsData(PrefService* prefs);
+ListValue* GetFlagsExperimentsData(PrefService* prefs);
// Returns true if one of the experiment flags has been flipped since startup.
bool IsRestartNeededToCommitChanges();
@@ -32,6 +31,6 @@ bool IsRestartNeededToCommitChanges();
void SetExperimentEnabled(
PrefService* prefs, const std::string& internal_name, bool enable);
-} // namespace Labs
+} // namespace about_flags
-#endif // CHROME_BROWSER_LABS_H_
+#endif // CHROME_BROWSER_ABOUT_FLAGS_H_
« no previous file with comments | « no previous file | chrome/browser/about_flags.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698