Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 3777005: Rename about:labs to about:flags, part 3/3 (Closed)

Created:
7 years, 9 months ago by Nico
Modified:
7 years, 2 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, brettw-cc_chromium.org, arv (Not doing code reviews), ben+cc_chromium.org
Visibility:
Public.

Description

Rename about:labs to about:flags, part 3/3 This renames the cc and h files, and renames the --no-labs switch to --no-experiments BUG=59139 TEST=about:flags still works Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62682

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 6

Patch Set 3 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -109 lines) Patch
A + chrome/browser/about_flags.h View 3 chunks +10 lines, -11 lines 0 comments Download
A + chrome/browser/about_flags.cc View 12 chunks +20 lines, -22 lines 0 comments Download
M chrome/browser/browser_about_handler.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/browser_main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/dom_ui/dom_ui_factory.cc View 1 2 5 chunks +6 lines, -6 lines 0 comments Download
A + chrome/browser/dom_ui/flags_ui.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + chrome/browser/dom_ui/flags_ui.cc View 1 2 9 chunks +38 lines, -37 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 2 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/profile_impl.cc View 1 2 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/flags.html View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
7 years, 9 months ago (2010-10-14 23:18:40 UTC) #1
viettrungluu
Rubberstamp LGTM with browser/flags.* -> browser/about_flags.* and namespace flags -> namespace about_flags (and maybe --no-flags ...
7 years, 9 months ago (2010-10-14 23:28:48 UTC) #2
Nico
http://codereview.chromium.org/3777005/diff/2001/3003 File chrome/browser/dom_ui/dom_ui_factory.cc (right): http://codereview.chromium.org/3777005/diff/2001/3003#newcode130 chrome/browser/dom_ui/dom_ui_factory.cc:130: return &NewDOMUI<HistoryUI2>; On 2010/10/14 23:28:49, viettrungluu wrote: > Maybe ...
7 years, 9 months ago (2010-10-14 23:31:34 UTC) #3
viettrungluu
On 2010/10/14 23:31:34, Nico wrote: > Maybe --no-experiments? (The table on about:flags has "Experiments" as ...
7 years, 9 months ago (2010-10-14 23:34:05 UTC) #4
Nico
7 years, 9 months ago (2010-10-14 23:39:48 UTC) #5
On 2010/10/14 23:34:05, viettrungluu wrote:
> On 2010/10/14 23:31:34, Nico wrote:
> > Maybe --no-experiments? (The table on about:flags has "Experiments" as
> heading)
> 
> SGTM.

Done as well.

Powered by Google App Engine
This is Rietveld 408576698