Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 377113003: Make WebGLRenderingContext.getSupportedExtensions() return type nullable (Closed)

Created:
6 years, 5 months ago by Jens Widell
Modified:
6 years, 5 months ago
CC:
blink-reviews, arv+blink, blink-reviews-html_chromium.org, abarth-chromium, dglazkov+blink, Rik, blink-reviews-bindings_chromium.org, Inactive, aandrey+blink_chromium.org, bajones, Zhenyao Mo
Base URL:
https://chromium.googlesource.com/chromium/blink.git@idl-nullable-method-return-type
Project:
blink
Visibility:
Public.

Description

Make WebGLRenderingContext.getSupportedExtensions()'s return type nullable This allows it to return null when the context is lost, without resorting to a custom binding for the method. BUG=390780 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177911

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -20 lines) Patch
M Source/bindings/core/v8/custom/V8WebGLRenderingContextCustom.cpp View 1 chunk +0 lines, -15 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContextBase.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/html/canvas/WebGLRenderingContextBase.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContextBase.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Jens Widell
PTAL This is a proof-of-concept that using Nullable<T> for nullable method return values is doable ...
6 years, 5 months ago (2014-07-10 14:32:15 UTC) #1
haraken
On 2014/07/10 14:32:15, Jens Lindström wrote: > PTAL > > This is a proof-of-concept that ...
6 years, 5 months ago (2014-07-10 14:45:17 UTC) #2
haraken
The base CL looks good, so this CL LGTM as well.
6 years, 5 months ago (2014-07-10 15:23:31 UTC) #3
Ken Russell (switch to Gerrit)
LGTM if this passes the WebGL conformance tests. The test conformance/context/context-lost.html should verify this behavior. ...
6 years, 5 months ago (2014-07-10 23:19:46 UTC) #4
Jens Widell
On 2014/07/10 23:19:46, Ken Russell wrote: > LGTM if this passes the WebGL conformance tests. ...
6 years, 5 months ago (2014-07-11 05:53:03 UTC) #5
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 5 months ago (2014-07-11 06:29:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/377113003/1
6 years, 5 months ago (2014-07-11 06:30:36 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 07:42:40 UTC) #8
Message was sent while issue was closed.
Change committed as 177911

Powered by Google App Engine
This is Rietveld 408576698