Source/core/html/canvas/WebGLRenderingContextBase.h - Issue 377113003: Make WebGLRenderingContext.getSupportedExtensions() return type nullable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/canvas/WebGLRenderingContextBase.h

Issue 377113003: Make WebGLRenderingContext.getSupportedExtensions() return type nullable (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@idl-nullable-method-return-type

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/core/v8/custom/V8WebGLRenderingContextCustom.cpp ('k') | Source/core/html/canvas/WebGLRenderingContextBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/canvas/WebGLRenderingContextBase.h

diff --git a/Source/core/html/canvas/WebGLRenderingContextBase.h b/Source/core/html/canvas/WebGLRenderingContextBase.h

index afa9619774cb74963830b03384933c9c9343b893..21367fdf4b7ba11f2da287f7b1f62c8e15e48bdb 100644

--- a/Source/core/html/canvas/WebGLRenderingContextBase.h

+++ b/Source/core/html/canvas/WebGLRenderingContextBase.h

@@ -26,6 +26,7 @@

#ifndef WebGLRenderingContextBase_h

#define WebGLRenderingContextBase_h

+#include "bindings/core/v8/Nullable.h"

#include "core/dom/ActiveDOMObject.h"

#include "core/html/canvas/CanvasRenderingContext.h"

#include "core/html/canvas/WebGLExtensionName.h"

@@ -200,7 +201,7 @@ public:

String getShaderInfoLog(WebGLShader*);

PassRefPtr<WebGLShaderPrecisionFormat> getShaderPrecisionFormat(GLenum shaderType, GLenum precisionType);

String getShaderSource(WebGLShader*);

- Vector<String> getSupportedExtensions();

+ Nullable<Vector<String> > getSupportedExtensions();

WebGLGetInfo getTexParameter(GLenum target, GLenum pname);

WebGLGetInfo getUniform(WebGLProgram*, const WebGLUniformLocation*);

PassRefPtr<WebGLUniformLocation> getUniformLocation(WebGLProgram*, const String&);