Update menu look and feel on Android

chrome/android/java/res/layout/four_button_menu_item.xml

Index: chrome/android/java/res/layout/four_button_menu_item.xml
diff --git a/chrome/android/java/res/layout/four_button_menu_item.xml b/chrome/android/java/res/layout/four_button_menu_item.xml
index 1e47144771d799245711f28e894a50aec9315798..1ea1c89dff4684a34b17f4c680224272468a769a 100644
--- a/chrome/android/java/res/layout/four_button_menu_item.xml
+++ b/chrome/android/java/res/layout/four_button_menu_item.xml
@@ -12,48 +12,47 @@
 
     <ImageButton
         android:id="@+id/button_one"
-        android:layout_width="wrap_content"
-        android:layout_height="match_parent"
-        android:layout_weight="1"
+        android:layout_width="48dp"

[aurimas (slooooooooow), 2014/07/08 23:49:44]

Why are you hardcoding the width of the button? This will create gaps between
the buttons?

[David Trainor- moved to gerrit, 2014/07/09 00:01:56]

Yes it will.  Talked to Roma and that's the desired behavior.  16dp in between
the buttons at 48 dp each button.  The spacers are 0dp with weight 1 to properly
fill the gaps (it ends up being 16 dp with the current measurements though).

[aurimas (slooooooooow), 2014/07/09 00:14:52]

THAT. IS. SO. UGLY.

+        android:layout_height="?android:attr/listPreferredItemHeightSmall"

[aurimas (slooooooooow), 2014/07/08 23:49:44]

Why is match parent the problem? Just set the parent height to be
listPreferredItemHeightSmall 

[David Trainor- moved to gerrit, 2014/07/09 00:01:56]

Good point!  I did try this earlier and IIRC for some reason it didn't work. 
But it should so I'll try again (I could have been testing something else and
messed it up).  The only reason the current menu works is that the dividers
happened to have the height set which bumps this view's height to the proper
size.

[David Trainor- moved to gerrit, 2014/07/09 00:15:17]

Just tried this again.  Didn't work.  I'm guessing the width/height are ignored
when the ListView inflates and adds the view.  I'll figure out why/if there is a
cleaner way around it tomorrow.

         android:background="?android:attr/listChoiceBackgroundIndicator"
         android:scaleType="center" />
 
     <View
-        android:layout_width="1dp"
+        android:layout_width="0dp"
         android:layout_height="?android:attr/listPreferredItemHeightSmall"
-        android:background="?android:attr/listDivider" />
+        android:layout_weight="1"
+        android:background="@null" />
 
     <ImageButton
         android:id="@+id/button_two"
-        android:layout_width="wrap_content"
-        android:layout_height="match_parent"
-        android:layout_weight="1"
+        android:layout_width="48dp"
+        android:layout_height="?android:attr/listPreferredItemHeightSmall"
         android:background="?android:attr/listChoiceBackgroundIndicator"
         android:scaleType="center" />
 
     <View
-        android:layout_width="1dp"
+        android:layout_width="0dp"
         android:layout_height="?android:attr/listPreferredItemHeightSmall"
-        android:background="?android:attr/listDivider" />
+        android:layout_weight="1"
+        android:background="@null" />
 
     <ImageButton
         android:id="@+id/button_three"
-        android:layout_width="wrap_content"
-        android:layout_height="match_parent"
-        android:layout_weight="1"
+        android:layout_width="48dp"
+        android:layout_height="?android:attr/listPreferredItemHeightSmall"
         android:background="?android:attr/listChoiceBackgroundIndicator"
         android:scaleType="center" />
     
     <View
-        android:layout_width="1dp"
+        android:layout_width="0dp"
         android:layout_height="?android:attr/listPreferredItemHeightSmall"
-        android:background="?android:attr/listDivider" />
+        android:layout_weight="1"
+        android:background="@null" />
 
     <ImageButton
         android:id="@+id/button_four"
-        android:layout_width="wrap_content"
-        android:layout_height="match_parent"
-        android:layout_weight="1"
+        android:layout_width="48dp"
+        android:layout_height="?android:attr/listPreferredItemHeightSmall"
         android:background="?android:attr/listChoiceBackgroundIndicator"
         android:scaleType="center" />