src/effects/SkOffsetImageFilter.cpp - Issue 376953003: Clean up SkImageFilter constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkOffsetImageFilter.cpp

Issue 376953003: Clean up SkImageFilter constructors. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Fix deserializing constructor for SkRectShaderImageFilter Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkOffsetImageFilter.cpp

diff --git a/src/effects/SkOffsetImageFilter.cpp b/src/effects/SkOffsetImageFilter.cpp

index 7680c62cfc948738b9f8e9dea124ef07666f50d7..15888cd8905b0555a043fd7af9189934b76953ed 100644

--- a/src/effects/SkOffsetImageFilter.cpp

+++ b/src/effects/SkOffsetImageFilter.cpp

@@ -97,7 +97,7 @@ void SkOffsetImageFilter::flatten(SkWriteBuffer& buffer) const {

}

SkOffsetImageFilter::SkOffsetImageFilter(SkScalar dx, SkScalar dy, SkImageFilter* input,

- const CropRect* cropRect) : INHERITED(input, cropRect) {

+ const CropRect* cropRect) : INHERITED(1, &input, cropRect) {

fOffset.set(dx, dy);

}