src/effects/SkMagnifierImageFilter.cpp - Issue 376953003: Clean up SkImageFilter constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkMagnifierImageFilter.cpp

Issue 376953003: Clean up SkImageFilter constructors. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Fix deserializing constructor for SkRectShaderImageFilter Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkMagnifierImageFilter.cpp

diff --git a/src/effects/SkMagnifierImageFilter.cpp b/src/effects/SkMagnifierImageFilter.cpp

index 99c0176a1131d14879e1093d1913552805413230..d7f98ded37a9afeaf9aacb06ddfb739c2e622bd0 100644

--- a/src/effects/SkMagnifierImageFilter.cpp

+++ b/src/effects/SkMagnifierImageFilter.cpp

@@ -246,9 +246,8 @@ SkMagnifierImageFilter::SkMagnifierImageFilter(SkReadBuffer& buffer)

(fSrcRect.fLeft >= 0) && (fSrcRect.fTop >= 0));

}

-// FIXME: implement single-input semantics

-SkMagnifierImageFilter::SkMagnifierImageFilter(const SkRect& srcRect, SkScalar inset)

- : INHERITED(0), fSrcRect(srcRect), fInset(inset) {

+SkMagnifierImageFilter::SkMagnifierImageFilter(const SkRect& srcRect, SkScalar inset, SkImageFilter* input)

reed1 2014/07/08 15:15:24 nit: 100 col

Stephen White 2014/07/08 15:33:30 Fixed.

+ : INHERITED(1, &input), fSrcRect(srcRect), fInset(inset) {

SkASSERT(srcRect.x() >= 0 && srcRect.y() >= 0 && inset >= 0);

}