src/effects/SkRectShaderImageFilter.cpp - Issue 376953003: Clean up SkImageFilter constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkRectShaderImageFilter.cpp

Issue 376953003: Clean up SkImageFilter constructors. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Fix deserializing constructor for SkRectShaderImageFilter Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkRectShaderImageFilter.cpp

diff --git a/src/effects/SkRectShaderImageFilter.cpp b/src/effects/SkRectShaderImageFilter.cpp

index bed017c32607c4bfbb71349de56e27bf6f6cbf01..6961facc10b4ef359ca1ccb0eba958b8b01a21c7 100644

--- a/src/effects/SkRectShaderImageFilter.cpp

+++ b/src/effects/SkRectShaderImageFilter.cpp

@@ -29,14 +29,14 @@ SkRectShaderImageFilter* SkRectShaderImageFilter::Create(SkShader* s, const Crop

}

SkRectShaderImageFilter::SkRectShaderImageFilter(SkShader* s, const CropRect* cropRect)

- : INHERITED(NULL, cropRect)

+ : INHERITED(0, NULL, cropRect)

, fShader(s) {

SkASSERT(s);

s->ref();

}

SkRectShaderImageFilter::SkRectShaderImageFilter(SkReadBuffer& buffer)

- : INHERITED(1, buffer) {

+ : INHERITED(0, buffer) {

fShader = buffer.readShader();

}