Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: net/cert/x509_certificate.h

Issue 376753002: Fix webui cert viewer showing wrong cert chain on NSS and no chain on OpenSSL. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix test Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cert/x509_certificate.h
diff --git a/net/cert/x509_certificate.h b/net/cert/x509_certificate.h
index 7aa48f068fa12867bd59beb9014dc078c60654ae..a6f8795133f22762f74cd17ee1e41b7631bd4de0 100644
--- a/net/cert/x509_certificate.h
+++ b/net/cert/x509_certificate.h
@@ -249,6 +249,12 @@ class NET_EXPORT X509Certificate
return intermediate_ca_certs_;
}
+ // Convenience method that fills |cert_chain| with the os_cert_handle()
+ // followed by GetIntermediateCertificates(). Ownership follows the "get"
+ // rule: it is the caller's responsibility to retain the elements of the
+ // result.
+ void GetCertificateChain(OSCertHandles* cert_chain) const;
Ryan Sleevi 2014/07/11 22:55:49 I realize you added this based on msw's comments,
msw 2014/07/11 23:01:15 I'll defer to you, my concern was duplicated code,
+
#if defined(OS_MACOSX)
// Does this certificate's usage allow SSL client authentication?
bool SupportsSSLClientAuth() const;

Powered by Google App Engine
This is Rietveld 408576698