chrome/browser/ui/certificate_dialogs.h - Issue 376753002: Fix webui cert viewer showing wrong cert chain on NSS and no chain on OpenSSL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/certificate_dialogs.h

Issue 376753002: Fix webui cert viewer showing wrong cert chain on NSS and no chain on OpenSSL. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix test Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/android/website_settings_popup_android.cc ('k') | chrome/browser/ui/certificate_dialogs.cc » ('j') | net/cert/x509_certificate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/certificate_dialogs.h

diff --git a/chrome/browser/ui/certificate_dialogs.h b/chrome/browser/ui/certificate_dialogs.h

index 9787ffc769774f118cbce5d66be215f9fe19984e..d7c914d0b07b9ff49a94d087e533fcd583d6c5c8 100644

--- a/chrome/browser/ui/certificate_dialogs.h

+++ b/chrome/browser/ui/certificate_dialogs.h

@@ -18,8 +18,12 @@ void ShowCertSelectFileDialog(ui::SelectFileDialog* select_file_dialog,

gfx::NativeWindow parent,

void* params);

-void ShowCertExportDialog(content::WebContents* web_contents,

- gfx::NativeWindow parent,

- net::X509Certificate::OSCertHandle cert);

+// Show a dialog to save the first certificate or the whole chain encompassed by

msw 2014/07/11 22:42:45 nit: I think omitting "the first certificate or" w

mattm 2014/07/11 22:49:50 The dialog lets the user choose between saving eit

msw 2014/07/11 23:02:02 Acknowledged, sorry for my confusion.

+// the iterators.

+void ShowCertExportDialog(

+ content::WebContents* web_contents,

+ gfx::NativeWindow parent,

+ net::X509Certificate::OSCertHandles::iterator certs_begin,

+ net::X509Certificate::OSCertHandles::iterator certs_end);

#endif // CHROME_BROWSER_UI_CERTIFICATE_DIALOGS_H_

« no previous file with comments | « chrome/browser/ui/android/website_settings_popup_android.cc ('k') | chrome/browser/ui/certificate_dialogs.cc » ('j') | net/cert/x509_certificate.h » ('J')