Fix webui cert viewer showing wrong cert chain on NSS and no chain on OpenSSL.

net/cert/x509_certificate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_CERT_X509_CERTIFICATE_H_
 #define NET_CERT_X509_CERTIFICATE_H_
 
 #include <string.h>
 
 #include <string>
@@ skipping 231 matching lines @@
   // Returns true if this object and |other| represent the same certificate.
   bool Equals(const X509Certificate* other) const;
 
   // Returns intermediate certificates added via AddIntermediateCertificate().
   // Ownership follows the "get" rule: it is the caller's responsibility to
   // retain the elements of the result.
   const OSCertHandles& GetIntermediateCertificates() const {
     return intermediate_ca_certs_;
   }
 
+  // Convenience method that fills |cert_chain| with the os_cert_handle()
+  // followed by GetIntermediateCertificates().  Ownership follows the "get"
+  // rule: it is the caller's responsibility to retain the elements of the
+  // result.
+  void GetCertificateChain(OSCertHandles* cert_chain) const;

[Ryan Sleevi, 2014/07/11 22:55:49]

I realize you added this based on msw's comments, but I'm not really a fan of
this.

X509Certificate exists as the canonical 'chain' type, and is meant to be what we
pass around for chains, because we rarely should be dealing in OSCertHandles.

[msw, 2014/07/11 23:01:15]

I'll defer to you, my concern was duplicated code, which yields maintenance
burdens and inconsistencies (some copies get fixed, some don't, etc.)...

+
 #if defined(OS_MACOSX)
   // Does this certificate's usage allow SSL client authentication?
   bool SupportsSSLClientAuth() const;
 
   // Returns a new CFArrayRef containing this certificate and its intermediate
   // certificates in the form expected by Security.framework and Keychain
   // Services, or NULL on failure.
   // The first item in the array will be this certificate, followed by its
   // intermediates, if any.
   CFArrayRef CreateOSCertChainForCert() const;
@@ skipping 223 matching lines @@
   // based on the type of the certificate.
   std::string default_nickname_;
 #endif
 
   DISALLOW_COPY_AND_ASSIGN(X509Certificate);
 };
 
 }  // namespace net
 
 #endif  // NET_CERT_X509_CERTIFICATE_H_