chrome/common/net/x509_certificate_model.h - Issue 376753002: Fix webui cert viewer showing wrong cert chain on NSS and no chain on OpenSSL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/net/x509_certificate_model.h

Issue 376753002: Fix webui cert viewer showing wrong cert chain on NSS and no chain on OpenSSL. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/certificate_viewer_webui.cc ('K') | « chrome/browser/ui/webui/options/certificate_manager_handler.cc ('k') | chrome/common/net/x509_certificate_model_nss.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/net/x509_certificate_model.h

diff --git a/chrome/common/net/x509_certificate_model.h b/chrome/common/net/x509_certificate_model.h

index e990828fb608aa8a6634227ebc5144b0f285616b..1a5d350dd5fe6e87d022a24212dcfd9d84460442 100644

--- a/chrome/common/net/x509_certificate_model.h

+++ b/chrome/common/net/x509_certificate_model.h

@@ -86,10 +86,6 @@ std::string HashCertSHA1(net::X509Certificate::OSCertHandle cert_handle);

// decoded U-label form. Otherwise, the string will be returned as is.

std::string ProcessIDN(const std::string& input);

-void GetCertChainFromCert(net::X509Certificate::OSCertHandle cert_handle,

- net::X509Certificate::OSCertHandles* cert_handles);

-void DestroyCertChain(net::X509Certificate::OSCertHandles* cert_handles);

std::string GetCMSString(const net::X509Certificate::OSCertHandles& cert_chain,

size_t start, size_t end);