Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4986)

Unified Diff: chrome/common/net/x509_certificate_model_nss.cc

Issue 376753002: Fix webui cert viewer showing wrong cert chain on NSS and no chain on OpenSSL. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/net/x509_certificate_model_nss.cc
diff --git a/chrome/common/net/x509_certificate_model_nss.cc b/chrome/common/net/x509_certificate_model_nss.cc
index 4648415affff70398d266ef0d4ff3719d8222243..7f9b3434fb7fc94128608cef810522e5ada67147 100644
--- a/chrome/common/net/x509_certificate_model_nss.cc
+++ b/chrome/common/net/x509_certificate_model_nss.cc
@@ -223,26 +223,6 @@ string HashCertSHA1(X509Certificate::OSCertHandle cert_handle) {
return HashCert(cert_handle, HASH_AlgSHA1, SHA1_LENGTH);
}
-void GetCertChainFromCert(X509Certificate::OSCertHandle cert_handle,
- X509Certificate::OSCertHandles* cert_handles) {
- CERTCertList* cert_list =
- CERT_GetCertChainFromCert(cert_handle, PR_Now(), certUsageSSLServer);
- CERTCertListNode* node;
- for (node = CERT_LIST_HEAD(cert_list);
- !CERT_LIST_END(node, cert_list);
- node = CERT_LIST_NEXT(node)) {
- cert_handles->push_back(CERT_DupCertificate(node->cert));
- }
- CERT_DestroyCertList(cert_list);
-}
-
-void DestroyCertChain(X509Certificate::OSCertHandles* cert_handles) {
- for (X509Certificate::OSCertHandles::iterator i(cert_handles->begin());
- i != cert_handles->end(); ++i)
- CERT_DestroyCertificate(*i);
- cert_handles->clear();
-}
-
string GetCMSString(const X509Certificate::OSCertHandles& cert_chain,
size_t start, size_t end) {
crypto::ScopedPLArenaPool arena(PORT_NewArena(1024));

Powered by Google App Engine
This is Rietveld 408576698