chrome/browser/ui/webui/options/certificate_manager_handler.cc - Issue 376753002: Fix webui cert viewer showing wrong cert chain on NSS and no chain on OpenSSL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/certificate_manager_handler.cc

Issue 376753002: Fix webui cert viewer showing wrong cert chain on NSS and no chain on OpenSSL. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/certificate_viewer_webui.cc ('K') | « chrome/browser/ui/webui/certificate_viewer_webui.cc ('k') | chrome/common/net/x509_certificate_model.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/certificate_manager_handler.cc

diff --git a/chrome/browser/ui/webui/options/certificate_manager_handler.cc b/chrome/browser/ui/webui/options/certificate_manager_handler.cc

index f5d3573fc9adc20a6ed1ddfa39d5123b27df578f..1335edc7f5b4480e5ad853a3ee06153e1d1bb649 100644

--- a/chrome/browser/ui/webui/options/certificate_manager_handler.cc

+++ b/chrome/browser/ui/webui/options/certificate_manager_handler.cc

@@ -983,8 +983,7 @@ void CertificateManagerHandler::Export(const base::ListValue* args) {

net::X509Certificate* cert = cert_id_map_->CallbackArgsToCert(args);

if (!cert)

return;

- ShowCertExportDialog(web_ui()->GetWebContents(), GetParentWindow(),

- cert->os_cert_handle());

+ ShowCertExportDialog(web_ui()->GetWebContents(), GetParentWindow(), cert);

}

void CertificateManagerHandler::Delete(const base::ListValue* args) {