Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 376733005: improve translateability of some OOBE strings (Closed)

Created:
6 years, 5 months ago by Evan Stade
Modified:
6 years, 5 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

improve translateability of some OOBE strings BUG=111425, 160586 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281801

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -33 lines) Patch
M chrome/app/chromeos_strings.grdp View 3 chunks +0 lines, -12 lines 0 comments Download
M chrome/app/chromium_strings.grd View 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/update_screen_handler.cc View 2 chunks +11 lines, -18 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Evan Stade
6 years, 5 months ago (2014-07-08 01:03:50 UTC) #1
Lei Zhang
lgtm
6 years, 5 months ago (2014-07-08 01:23:51 UTC) #2
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 5 months ago (2014-07-08 01:27:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/376733005/20001
6 years, 5 months ago (2014-07-08 01:28:16 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-08 05:08:45 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-08 08:50:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/35966)
6 years, 5 months ago (2014-07-08 08:50:37 UTC) #7
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 5 months ago (2014-07-08 17:36:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/376733005/20001
6 years, 5 months ago (2014-07-08 17:37:27 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-08 17:40:39 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 20:01:04 UTC) #11
Message was sent while issue was closed. 
Change committed as 281801

Powered by Google App Engine
This is Rietveld 408576698