Issue 375773002: Fixes for re-enabling more MSVC level 4 warnings: net/spdy/ edition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 375773002: Fixes for re-enabling more MSVC level 4 warnings: net/spdy/ edition (Closed)

Created:
6 years, 5 months ago by Peter Kasting

Modified:
6 years, 5 months ago

Reviewers:
Johnny

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixes for re-enabling more MSVC level 4 warnings: net/spdy/ edition This contains fixes for the following sorts of issues: * Signedness mismatch * Octal escape sequence terminated by decimal number BUG=81439 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281887

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -7 lines)			Patch
M	net/spdy/buffered_spdy_framer_unittest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/spdy/spdy_frame_reader_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/spdy/spdy_framer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/spdy/spdy_framer_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/spdy/spdy_protocol_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/spdy/spdy_proxy_client_socket_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkasting@chromium.org/375773002/1

6 years, 5 months ago (2014-07-08 18:53:02 UTC) #4

Message was sent while issue was closed.

Change committed as 281887

Expand Messages | Collapse Messages