net/spdy/spdy_protocol_test.cc - Issue 375773002: Fixes for re-enabling more MSVC level 4 warnings: net/spdy/ edition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_protocol_test.cc

Issue 375773002: Fixes for re-enabling more MSVC level 4 warnings: net/spdy/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/spdy_protocol_test.cc

diff --git a/net/spdy/spdy_protocol_test.cc b/net/spdy/spdy_protocol_test.cc

index aeae43dd6b823ce35d95bd916e1c6da86e0193d3..0e49207e11d45a1879ef164436a5a6b3c2063cdd 100644

--- a/net/spdy/spdy_protocol_test.cc

+++ b/net/spdy/spdy_protocol_test.cc

@@ -50,7 +50,7 @@ INSTANTIATE_TEST_CASE_P(SpdyProtocolDeathTests,

TEST_P(SpdyProtocolDeathTest, TestSpdySettingsAndIdOutOfBounds) {

scoped_ptr<SettingsFlagsAndId> flags_and_id;

- EXPECT_DFATAL(flags_and_id.reset(new SettingsFlagsAndId(1, ~0)),

+ EXPECT_DFATAL(flags_and_id.reset(new SettingsFlagsAndId(1, 0xFFFFFFFF)),

"SPDY setting ID too large.");

// Make sure that we get expected values in opt mode.

if (flags_and_id.get() != NULL) {

« no previous file with comments | « net/spdy/spdy_framer_test.cc ('k') | net/spdy/spdy_proxy_client_socket_unittest.cc » ('j') | no next file with comments »