Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Side by Side Diff: net/spdy/spdy_protocol_test.cc

Issue 375773002: Fixes for re-enabling more MSVC level 4 warnings: net/spdy/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/spdy/spdy_framer_test.cc ('k') | net/spdy/spdy_proxy_client_socket_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/spdy/spdy_protocol.h" 5 #include "net/spdy/spdy_protocol.h"
6 6
7 #include <limits> 7 #include <limits>
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 class SpdyProtocolDeathTest : public SpdyProtocolTest {}; 43 class SpdyProtocolDeathTest : public SpdyProtocolTest {};
44 44
45 // All tests are run with two different SPDY versions: SPDY/2 and SPDY/3. 45 // All tests are run with two different SPDY versions: SPDY/2 and SPDY/3.
46 INSTANTIATE_TEST_CASE_P(SpdyProtocolDeathTests, 46 INSTANTIATE_TEST_CASE_P(SpdyProtocolDeathTests,
47 SpdyProtocolDeathTest, 47 SpdyProtocolDeathTest,
48 ::testing::Values(SPDY2, SPDY3)); 48 ::testing::Values(SPDY2, SPDY3));
49 49
50 TEST_P(SpdyProtocolDeathTest, TestSpdySettingsAndIdOutOfBounds) { 50 TEST_P(SpdyProtocolDeathTest, TestSpdySettingsAndIdOutOfBounds) {
51 scoped_ptr<SettingsFlagsAndId> flags_and_id; 51 scoped_ptr<SettingsFlagsAndId> flags_and_id;
52 52
53 EXPECT_DFATAL(flags_and_id.reset(new SettingsFlagsAndId(1, ~0)), 53 EXPECT_DFATAL(flags_and_id.reset(new SettingsFlagsAndId(1, 0xFFFFFFFF)),
54 "SPDY setting ID too large."); 54 "SPDY setting ID too large.");
55 // Make sure that we get expected values in opt mode. 55 // Make sure that we get expected values in opt mode.
56 if (flags_and_id.get() != NULL) { 56 if (flags_and_id.get() != NULL) {
57 EXPECT_EQ(1, flags_and_id->flags()); 57 EXPECT_EQ(1, flags_and_id->flags());
58 EXPECT_EQ(static_cast<SpdyPingId>(0xffffff), flags_and_id->id()); 58 EXPECT_EQ(static_cast<SpdyPingId>(0xffffff), flags_and_id->id());
59 } 59 }
60 } 60 }
61 61
62 } // namespace net 62 } // namespace net
OLDNEW
« no previous file with comments | « net/spdy/spdy_framer_test.cc ('k') | net/spdy/spdy_proxy_client_socket_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698