Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 375703008: Update service_worker to use results.AddValue(...) (Closed)

Created:
6 years, 5 months ago by nednguyen
Modified:
6 years, 5 months ago
Reviewers:
nduca
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update service_worker to use results.AddValue(...) BUG=391943 TBR=nduca@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281933

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M tools/perf/benchmarks/service_worker.py View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 5 months ago (2014-07-08 21:16:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/375703008/1
6 years, 5 months ago (2014-07-08 21:19:29 UTC) #2
nduca
lgtm
6 years, 5 months ago (2014-07-08 23:22:21 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...
6 years, 5 months ago (2014-07-09 00:16:23 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 04:43:38 UTC) #5
Message was sent while issue was closed. 
Change committed as 281933

Powered by Google App Engine
This is Rietveld 408576698