Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Side by Side Diff: tools/perf/benchmarks/service_worker.py

Issue 375703008: Update service_worker to use results.AddValue(...) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import page_sets 5 import page_sets
6 from telemetry import benchmark 6 from telemetry import benchmark
7 from telemetry.page import page_measurement 7 from telemetry.page import page_measurement
8 from telemetry.value import scalar
8 9
9 10
10 class _ServiceWorkerMeasurement(page_measurement.PageMeasurement): 11 class _ServiceWorkerMeasurement(page_measurement.PageMeasurement):
11 def CustomizeBrowserOptions(self, options): 12 def CustomizeBrowserOptions(self, options):
12 options.AppendExtraBrowserArgs([ 13 options.AppendExtraBrowserArgs([
13 '--enable-experimental-web-platform-features' 14 '--enable-experimental-web-platform-features'
14 ]) 15 ])
15 16
16 def MeasurePage(self, _, tab, results): 17 def MeasurePage(self, _, tab, results):
17 tab.WaitForJavaScriptExpression('window.done', 40) 18 tab.WaitForJavaScriptExpression('window.done', 40)
18 json = tab.EvaluateJavaScript('window.results') 19 json = tab.EvaluateJavaScript('window.results')
19 for key, value in json.iteritems(): 20 for key, value in json.iteritems():
20 results.Add(key, value['units'], value['value']) 21 results.AddValue(scalar.ScalarValue(
22 results.current_page, key, value['units'], value['value']))
21 23
22 24
23 @benchmark.Disabled 25 @benchmark.Disabled
24 class ServiceWorkerPerfTest(benchmark.Benchmark): 26 class ServiceWorkerPerfTest(benchmark.Benchmark):
25 test = _ServiceWorkerMeasurement 27 test = _ServiceWorkerMeasurement
26 page_set = page_sets.ServiceWorkerPageSet 28 page_set = page_sets.ServiceWorkerPageSet
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698