Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: tools/perf/benchmarks/service_worker.py

Issue 375703008: Update service_worker to use results.AddValue(...) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/service_worker.py
diff --git a/tools/perf/benchmarks/service_worker.py b/tools/perf/benchmarks/service_worker.py
index 891dad26abebe13fbab59db67b7b0c94a2077ba8..7f72753605ba79630305b90ef24e1b492333b2b9 100644
--- a/tools/perf/benchmarks/service_worker.py
+++ b/tools/perf/benchmarks/service_worker.py
@@ -5,6 +5,7 @@
import page_sets
from telemetry import benchmark
from telemetry.page import page_measurement
+from telemetry.value import scalar
class _ServiceWorkerMeasurement(page_measurement.PageMeasurement):
@@ -17,7 +18,8 @@ class _ServiceWorkerMeasurement(page_measurement.PageMeasurement):
tab.WaitForJavaScriptExpression('window.done', 40)
json = tab.EvaluateJavaScript('window.results')
for key, value in json.iteritems():
- results.Add(key, value['units'], value['value'])
+ results.AddValue(scalar.ScalarValue(
+ results.current_page, key, value['units'], value['value']))
@benchmark.Disabled
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698