Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.cpp

Issue 374593002: Support ignorance of base class finalizers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use early returns instead of fallthrough Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.cpp
diff --git a/tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.cpp b/tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.cpp
index c1a9ec7187bd405b8b4b27991191195fe88f7a9e..e68fbdabce3292f9ac9e876045aefa695df5bb1e 100644
--- a/tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.cpp
+++ b/tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.cpp
@@ -6,7 +6,12 @@
namespace WebCore {
-void Mixin::trace(Visitor* visitor)
+void MixinFinalizable::trace(Visitor* visitor)
+{
+ visitor->trace(m_onHeap);
+}
+
+void MixinNotFinalizable::trace(Visitor* visitor)
{
visitor->trace(m_onHeap);
}
@@ -14,13 +19,19 @@ void Mixin::trace(Visitor* visitor)
void NeedsFinalizer::trace(Visitor* visitor)
{
visitor->trace(m_obj);
- Mixin::trace(visitor);
+ MixinFinalizable::trace(visitor);
}
void HasFinalizer::trace(Visitor* visitor)
{
visitor->trace(m_obj);
- Mixin::trace(visitor);
+ MixinFinalizable::trace(visitor);
+}
+
+void NeedsNoFinalization::trace(Visitor* visitor)
+{
+ visitor->trace(m_obj);
+ MixinNotFinalizable::trace(visitor);
}
}

Powered by Google App Engine
This is Rietveld 408576698