tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.txt - Issue 374593002: Support ignorance of base class finalizers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.txt

Issue 374593002: Support ignorance of base class finalizers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use early returns instead of fallthrough Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.cpp ('k') | tools/clang/blink_gc_plugin/tests/heap/stubs.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.txt

diff --git a/tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.txt b/tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.txt

index f42a0d668cb76378e17e488e2649466a76449f67..0bf93d58d01104ff3f389cfacc5eb29957cb0e99 100644

--- a/tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.txt

+++ b/tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.txt

@@ -1,8 +1,8 @@

In file included from class_requires_finalization_mixin.cpp:5:

-./class_requires_finalization_mixin.h:23:1: warning: [blink-gc] Class 'NeedsFinalizer' requires finalization.

-class NeedsFinalizer : public GarbageCollected<NeedsFinalizer>, public Mixin {

+./class_requires_finalization_mixin.h:30:1: warning: [blink-gc] Class 'NeedsFinalizer' requires finalization.

+class NeedsFinalizer

-./class_requires_finalization_mixin.h:23:65: note: [blink-gc] Base class 'Mixin' requiring finalization declared here:

-class NeedsFinalizer : public GarbageCollected<NeedsFinalizer>, public Mixin {

- ^

+./class_requires_finalization_mixin.h:32:7: note: [blink-gc] Base class 'MixinFinalizable' requiring finalization declared here:

+ , public MixinFinalizable {

+ ^

1 warning generated.