Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1530)

Unified Diff: tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.h

Issue 374593002: Support ignorance of base class finalizers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use early returns instead of fallthrough Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.h
diff --git a/tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.h b/tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.h
index f321281d3622f3b989c9615560282d2adc5ebfb0..ed1d86dcdb2ec5a6d56f4416aa3464be1fc9c99b 100644
--- a/tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.h
+++ b/tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.h
@@ -12,7 +12,7 @@ namespace WebCore {
class OffHeap : public RefCounted<OffHeap> { };
class OnHeap : public GarbageCollected<OnHeap> { };
-class Mixin : public GarbageCollectedMixin {
+class MixinFinalizable : public GarbageCollectedMixin {
public:
void trace(Visitor*);
private:
@@ -20,7 +20,16 @@ private:
Member<OnHeap> m_onHeap;
};
-class NeedsFinalizer : public GarbageCollected<NeedsFinalizer>, public Mixin {
+class MixinNotFinalizable : public GarbageCollectedMixin {
+public:
+ void trace(Visitor*);
+private:
+ Member<OnHeap> m_onHeap;
+};
+
+class NeedsFinalizer
+ : public GarbageCollected<NeedsFinalizer>
+ , public MixinFinalizable {
USING_GARBAGE_COLLECTED_MIXIN(NeedsFinalizer);
public:
void trace(Visitor*);
@@ -29,7 +38,7 @@ private:
};
class HasFinalizer : public GarbageCollectedFinalized<HasFinalizer>,
- public Mixin {
+ public MixinFinalizable {
USING_GARBAGE_COLLECTED_MIXIN(HasFinalizer);
public:
void trace(Visitor*);
@@ -37,6 +46,17 @@ private:
Member<OnHeap> m_obj;
};
+class NeedsNoFinalization
+ : public GarbageCollected<NeedsNoFinalization>
+ , public MixinNotFinalizable
+ , public ScriptWrappable {
+ USING_GARBAGE_COLLECTED_MIXIN(NeedsNoFinalization);
+public:
+ void trace(Visitor*);
+private:
+ Member<OnHeap> m_obj;
+};
+
}
#endif

Powered by Google App Engine
This is Rietveld 408576698