Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h

Issue 374193002: gpu: Optimize and cleanup code used for CHROMIUM_copy_texture. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address reviewers commnets Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h
diff --git a/gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h b/gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h
index 17290f8ed22f35fb2f8c69119a4e41af96a67a75..055b0e61884ed0f059490e6285dadf0824b5085d 100644
--- a/gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h
+++ b/gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h
@@ -30,16 +30,17 @@ class GPU_EXPORT CopyTextureCHROMIUMResourceManager {
void Destroy();
void DoCopyTexture(const gles2::GLES2Decoder* decoder, GLenum source_target,
- GLenum dest_target, GLuint source_id, GLuint dest_id,
- GLint level, GLsizei width, GLsizei height,
+ GLuint source_id, GLuint dest_id, GLint level,
+ GLenum internal_format, GLsizei width, GLsizei height,
bool flip_y, bool premultiply_alpha,
bool unpremultiply_alpha);
reveman 2014/07/10 18:13:18 can you "cl format" this file to clean up these pa
dshwang 2014/07/10 19:45:34 I wanted to run "cl format" but it changes many li
reveman 2014/07/10 20:20:49 Yes, I think that was a good call. Thanks.
// This will apply a transform on the source texture before copying to
// destination texture.
void DoCopyTextureWithTransform(const gles2::GLES2Decoder* decoder,
- GLenum source_target, GLenum dest_target,
- GLuint source_id, GLuint dest_id, GLint level,
+ GLenum source_target, GLuint source_id,
+ GLuint dest_id, GLint level,
+ GLenum internal_format,
GLsizei width, GLsizei height, bool flip_y,
bool premultiply_alpha,
bool unpremultiply_alpha,

Powered by Google App Engine
This is Rietveld 408576698