content/common/gpu/media/android_video_decode_accelerator.cc - Issue 374193002: gpu: Optimize and cleanup code used for CHROMIUM_copy_texture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/android_video_decode_accelerator.cc

Issue 374193002: gpu: Optimize and cleanup code used for CHROMIUM_copy_texture. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address reviewers commnets Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h » ('j') | gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/media/android_video_decode_accelerator.cc

diff --git a/content/common/gpu/media/android_video_decode_accelerator.cc b/content/common/gpu/media/android_video_decode_accelerator.cc

index f72e1b257d77c8bc9f5c243ab2f1e34d5faad042..a5372094ea755a4d0416923640c32e1e69d8569a 100644

--- a/content/common/gpu/media/android_video_decode_accelerator.cc

+++ b/content/common/gpu/media/android_video_decode_accelerator.cc

@@ -358,8 +358,8 @@ void AndroidVideoDecodeAccelerator::SendCurrentSurfaceToClient(

// 2. SurfaceTexture requires us to apply a transform matrix when we show

// the texture.

copier_->DoCopyTexture(gl_decoder_.get(), GL_TEXTURE_EXTERNAL_OES,

- GL_TEXTURE_2D, surface_texture_id_,

- picture_buffer_texture_id, 0, size_.width(),

+ surface_texture_id_, picture_buffer_texture_id,

+ 0, GL_RGBA, size_.width(),

size_.height(), false, false, false);

base::MessageLoop::current()->PostTask(

« no previous file with comments | « no previous file | gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h » ('j') | gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h » ('J')