gpu: Optimize and cleanup code used for CHROMIUM_copy_texture.

gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef GPU_COMMAND_BUFFER_SERVICE_GLES2_CMD_COPY_TEXTURE_CHROMIUM_H_
 #define GPU_COMMAND_BUFFER_SERVICE_GLES2_CMD_COPY_TEXTURE_CHROMIUM_H_
 
 #include <vector>
 
 #include "base/containers/hash_tables.h"
 #include "gpu/command_buffer/service/gl_utils.h"
 #include "gpu/gpu_export.h"
 
 namespace gpu {
 namespace gles2 {
 
 class GLES2Decoder;
 
 }  // namespace gles2.
 
 // This class encapsulates the resources required to implement the
 // GL_CHROMIUM_copy_texture extension.  The copy operation is performed
 // via a blit to a framebuffer object.

[reveman, 2014/07/10 18:13:18]

Please update this comment. Blit to FBO is no longer the only way this copy
operation is performed. I think it would also be nice to mention that
source_target is assumed to be TEXTURE_2D now that you removed that parameter
from the copy functions.

[dshwang, 2014/07/10 19:45:34]

yes, Done.

 class GPU_EXPORT CopyTextureCHROMIUMResourceManager {
  public:
   CopyTextureCHROMIUMResourceManager();
   ~CopyTextureCHROMIUMResourceManager();
 
   void Initialize(const gles2::GLES2Decoder* decoder);
   void Destroy();
 
   void DoCopyTexture(const gles2::GLES2Decoder* decoder, GLenum source_target,
-                     GLenum dest_target, GLuint source_id, GLuint dest_id,
-                     GLint level, GLsizei width, GLsizei height,
+                     GLuint source_id, GLuint dest_id, GLint level,
+                     GLenum internal_format, GLsizei width, GLsizei height,
                      bool flip_y, bool premultiply_alpha,
                      bool unpremultiply_alpha);

[reveman, 2014/07/10 18:13:18]

can you "cl format" this file to clean up these parameters while here?

it might also be good to add a comment above this function to explain what
|internalformat| is.

[dshwang, 2014/07/10 19:45:34]

I wanted to run "cl format" but it changes many lines, which might make reviewer
confused. Now I gladly run "cl format". :)

[reveman, 2014/07/10 20:20:49]

Yes, I think that was a good call. Thanks.

 
   // This will apply a transform on the source texture before copying to
   // destination texture.
   void DoCopyTextureWithTransform(const gles2::GLES2Decoder* decoder,
-                                  GLenum source_target, GLenum dest_target,
-                                  GLuint source_id, GLuint dest_id, GLint level,
+                                  GLenum source_target, GLuint source_id,
+                                  GLuint dest_id, GLint level,
+                                  GLenum internal_format,
                                   GLsizei width, GLsizei height, bool flip_y,
                                   bool premultiply_alpha,
                                   bool unpremultiply_alpha,
                                   const GLfloat transform_matrix[16]);
 
   // The attributes used during invocation of the extension.
   static const GLuint kVertexPositionAttrib = 0;
 
  private:
   struct ProgramInfo {
@@ skipping 18 matching lines @@
   ProgramMap programs_;
   GLuint buffer_id_;
   GLuint framebuffer_;
 
   DISALLOW_COPY_AND_ASSIGN(CopyTextureCHROMIUMResourceManager);
 };
 
 }  // namespace gpu.
 
 #endif  // GPU_COMMAND_BUFFER_SERVICE_GLES2_CMD_COPY_TEXTURE_CHROMIUM_H_