Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 373903003: Fix viewport computation in Mac UC (Closed)

Created:
6 years, 5 months ago by ccameron
Modified:
6 years, 5 months ago
Reviewers:
danakj, palmer, pfeldman
CC:
chromium-reviews, vsevik, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, James Su, jam, penghuang+watch_chromium.org, yurys, nona+watch_chromium.org, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, cc-bugs_chromium.org, aandrey+blink_chromium.org, pfeldman, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix viewport computation in Mac UC Replace all instances of viewport_size with scrollable_viewport_size, as this deceptive variable name was root cause of the bug. BUG=391386 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281917

Patch Set 1 #

Patch Set 2 : Update IPC #

Patch Set 3 : Cut out the bit I want to submit now #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -19 lines) Patch
M cc/output/compositor_frame_metadata.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/devtools/renderer_overrides_handler.cc View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 2 3 4 chunks +7 lines, -5 lines 0 comments Download
M content/common/cc_messages.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
ccameron
ptal
6 years, 5 months ago (2014-07-08 00:28:38 UTC) #1
danakj
LGTM
6 years, 5 months ago (2014-07-08 00:30:33 UTC) #2
ccameron
Victimizing pfeldman for content/browser/devtools review and palmer for _messages.h review.
6 years, 5 months ago (2014-07-08 00:36:29 UTC) #3
palmer
lgtm
6 years, 5 months ago (2014-07-08 20:02:30 UTC) #4
pfeldman
lgtm
6 years, 5 months ago (2014-07-08 20:07:14 UTC) #5
ccameron
Thanks!
6 years, 5 months ago (2014-07-08 20:19:01 UTC) #6
ccameron
The CQ bit was checked by ccameron@chromium.org
6 years, 5 months ago (2014-07-08 20:19:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/373903003/40001
6 years, 5 months ago (2014-07-08 20:21:30 UTC) #8
ccameron
The CQ bit was checked by ccameron@chromium.org
6 years, 5 months ago (2014-07-08 20:48:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/373903003/60001
6 years, 5 months ago (2014-07-08 20:49:50 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...
6 years, 5 months ago (2014-07-09 00:18:12 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 04:05:51 UTC) #12
Message was sent while issue was closed. 
Change committed as 281917

Powered by Google App Engine
This is Rietveld 408576698