Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 373903003: Fix viewport computation in Mac UC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/render_widget_host_impl.cc ('k') | content/common/cc_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_widget_host_view_android.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc
index a0e4dda321567274cd4ee2531875f052c5a2fecf..d63f4a818a1e87c68a35f9dce8bdd90534f5ebcd 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.cc
+++ b/content/browser/renderer_host/render_widget_host_view_android.cc
@@ -127,7 +127,8 @@ OverscrollGlow::DisplayParameters CreateOverscrollDisplayParameters(
// the viewport and offset by the distance of each viewport edge to the
// respective content edge.
OverscrollGlow::DisplayParameters params;
- params.size = gfx::ScaleSize(frame_metadata.viewport_size, scale_factor);
+ params.size = gfx::ScaleSize(
+ frame_metadata.scrollable_viewport_size, scale_factor);
params.edge_offsets[EdgeEffect::EDGE_TOP] =
-frame_metadata.root_scroll_offset.y() * scale_factor;
params.edge_offsets[EdgeEffect::EDGE_LEFT] =
@@ -135,11 +136,11 @@ OverscrollGlow::DisplayParameters CreateOverscrollDisplayParameters(
params.edge_offsets[EdgeEffect::EDGE_BOTTOM] =
(frame_metadata.root_layer_size.height() -
frame_metadata.root_scroll_offset.y() -
- frame_metadata.viewport_size.height()) * scale_factor;
+ frame_metadata.scrollable_viewport_size.height()) * scale_factor;
params.edge_offsets[EdgeEffect::EDGE_RIGHT] =
(frame_metadata.root_layer_size.width() -
frame_metadata.root_scroll_offset.x() -
- frame_metadata.viewport_size.width()) * scale_factor;
+ frame_metadata.scrollable_viewport_size.width()) * scale_factor;
params.device_scale_factor = frame_metadata.device_scale_factor;
return params;
@@ -159,7 +160,8 @@ bool HasFixedPageScale(const cc::CompositorFrameMetadata& frame_metadata) {
bool HasMobileViewport(const cc::CompositorFrameMetadata& frame_metadata) {
float window_width_dip =
- frame_metadata.page_scale_factor * frame_metadata.viewport_size.width();
+ frame_metadata.page_scale_factor *
+ frame_metadata.scrollable_viewport_size.width();
float content_width_css = frame_metadata.root_layer_size.width();
return content_width_css <= window_width_dip + kMobileViewportWidthEpsilon;
}
@@ -998,7 +1000,7 @@ void RenderWidgetHostViewAndroid::OnFrameMetadataUpdated(
gfx::Vector2dF(frame_metadata.min_page_scale_factor,
frame_metadata.max_page_scale_factor),
frame_metadata.root_layer_size,
- frame_metadata.viewport_size,
+ frame_metadata.scrollable_viewport_size,
frame_metadata.location_bar_offset,
frame_metadata.location_bar_content_translation,
frame_metadata.overdraw_bottom_height);
« no previous file with comments | « content/browser/renderer_host/render_widget_host_impl.cc ('k') | content/common/cc_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698