Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1196)

Side by Side Diff: content/browser/devtools/renderer_overrides_handler.cc

Issue 373903003: Fix viewport computation in Mac UC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/devtools/renderer_overrides_handler.h" 5 #include "content/browser/devtools/renderer_overrides_handler.h"
6 6
7 #include <map> 7 #include <map>
8 #include <string> 8 #include <string>
9 9
10 #include "base/barrier_closure.h" 10 #include "base/barrier_closure.h"
(...skipping 191 matching lines...) Expand 10 before | Expand all | Expand 10 after
202 return; 202 return;
203 203
204 last_frame_time_ = base::TimeTicks::Now(); 204 last_frame_time_ = base::TimeTicks::Now();
205 205
206 RenderWidgetHostViewBase* view = static_cast<RenderWidgetHostViewBase*>( 206 RenderWidgetHostViewBase* view = static_cast<RenderWidgetHostViewBase*>(
207 host->GetView()); 207 host->GetView());
208 // TODO(vkuzkokov): do not use previous frame metadata. 208 // TODO(vkuzkokov): do not use previous frame metadata.
209 cc::CompositorFrameMetadata& metadata = last_compositor_frame_metadata_; 209 cc::CompositorFrameMetadata& metadata = last_compositor_frame_metadata_;
210 210
211 float page_scale = metadata.page_scale_factor; 211 float page_scale = metadata.page_scale_factor;
212 gfx::SizeF viewport_size_dip = gfx::ScaleSize(metadata.viewport_size, 212 gfx::SizeF viewport_size_dip = gfx::ScaleSize(
213 page_scale); 213 metadata.scrollable_viewport_size, page_scale);
214 214
215 float total_bar_height_dip = metadata.location_bar_content_translation.y() + 215 float total_bar_height_dip = metadata.location_bar_content_translation.y() +
216 metadata.overdraw_bottom_height; 216 metadata.overdraw_bottom_height;
217 gfx::SizeF screen_size_dip(viewport_size_dip.width(), 217 gfx::SizeF screen_size_dip(viewport_size_dip.width(),
218 viewport_size_dip.height() + total_bar_height_dip); 218 viewport_size_dip.height() + total_bar_height_dip);
219 219
220 std::string format; 220 std::string format;
221 int quality = kDefaultScreenshotQuality; 221 int quality = kDefaultScreenshotQuality;
222 double scale = 1; 222 double scale = 1;
223 double max_width = -1; 223 double max_width = -1;
(...skipping 377 matching lines...) Expand 10 before | Expand all | Expand 10 after
601 response_metadata->SetDouble( 601 response_metadata->SetDouble(
602 devtools::Page::ScreencastFrameMetadata::kParamOffsetBottom, 602 devtools::Page::ScreencastFrameMetadata::kParamOffsetBottom,
603 metadata.overdraw_bottom_height); 603 metadata.overdraw_bottom_height);
604 604
605 base::DictionaryValue* viewport = new base::DictionaryValue(); 605 base::DictionaryValue* viewport = new base::DictionaryValue();
606 viewport->SetDouble(devtools::DOM::Rect::kParamX, 606 viewport->SetDouble(devtools::DOM::Rect::kParamX,
607 metadata.root_scroll_offset.x()); 607 metadata.root_scroll_offset.x());
608 viewport->SetDouble(devtools::DOM::Rect::kParamY, 608 viewport->SetDouble(devtools::DOM::Rect::kParamY,
609 metadata.root_scroll_offset.y()); 609 metadata.root_scroll_offset.y());
610 viewport->SetDouble(devtools::DOM::Rect::kParamWidth, 610 viewport->SetDouble(devtools::DOM::Rect::kParamWidth,
611 metadata.viewport_size.width()); 611 metadata.scrollable_viewport_size.width());
612 viewport->SetDouble(devtools::DOM::Rect::kParamHeight, 612 viewport->SetDouble(devtools::DOM::Rect::kParamHeight,
613 metadata.viewport_size.height()); 613 metadata.scrollable_viewport_size.height());
614 response_metadata->Set( 614 response_metadata->Set(
615 devtools::Page::ScreencastFrameMetadata::kParamViewport, viewport); 615 devtools::Page::ScreencastFrameMetadata::kParamViewport, viewport);
616 616
617 gfx::SizeF viewport_size_dip = gfx::ScaleSize(metadata.viewport_size, 617 gfx::SizeF viewport_size_dip = gfx::ScaleSize(
618 metadata.page_scale_factor); 618 metadata.scrollable_viewport_size, metadata.page_scale_factor);
619 response_metadata->SetDouble( 619 response_metadata->SetDouble(
620 devtools::Page::ScreencastFrameMetadata::kParamDeviceWidth, 620 devtools::Page::ScreencastFrameMetadata::kParamDeviceWidth,
621 viewport_size_dip.width()); 621 viewport_size_dip.width());
622 response_metadata->SetDouble( 622 response_metadata->SetDouble(
623 devtools::Page::ScreencastFrameMetadata::kParamDeviceHeight, 623 devtools::Page::ScreencastFrameMetadata::kParamDeviceHeight,
624 viewport_size_dip.height() + 624 viewport_size_dip.height() +
625 metadata.location_bar_content_translation.y() + 625 metadata.location_bar_content_translation.y() +
626 metadata.overdraw_bottom_height); 626 metadata.overdraw_bottom_height);
627 response_metadata->SetDouble( 627 response_metadata->SetDouble(
628 devtools::Page::ScreencastFrameMetadata::kParamScrollOffsetX, 628 devtools::Page::ScreencastFrameMetadata::kParamScrollOffsetX,
(...skipping 371 matching lines...) Expand 10 before | Expand all | Expand 10 after
1000 return NULL; 1000 return NULL;
1001 } 1001 }
1002 event.data.pinchUpdate.scale = static_cast<float>(scale); 1002 event.data.pinchUpdate.scale = static_cast<float>(scale);
1003 } 1003 }
1004 1004
1005 host->ForwardGestureEvent(event); 1005 host->ForwardGestureEvent(event);
1006 return command->SuccessResponse(NULL); 1006 return command->SuccessResponse(NULL);
1007 } 1007 }
1008 1008
1009 } // namespace content 1009 } // namespace content
OLDNEW
« no previous file with comments | « cc/trees/layer_tree_host_impl_unittest.cc ('k') | content/browser/renderer_host/render_widget_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698