Issue 373873002: Fixes for re-enabling more MSVC level 4 warnings: content/browser/ edition

Issue 373873002: Fixes for re-enabling more MSVC level 4 warnings: content/browser/ edition (Closed)

Created:
6 years, 5 months ago by Peter Kasting

Modified:
6 years, 5 months ago

Reviewers:
sky

CC:
chromium-reviews, tzik, jam, nasko+codewatch_chromium.org, ericu+idb_chromium.org, dgrogan, dmazzoni+watch_chromium.org, aandrey+blink_chromium.org, jdduke+watch_chromium.org, jsbell+serviceworker_chromium.org, vsevik, aboxhall+watch_chromium.org, alecflett, darin-cc_chromium.org, devtools-reviews_chromium.org, creis+watch_chromium.org, dtseng+watch_chromium.org, yuzo+watch_chromium.org, paulirish+reviews_chromium.org, nhiroki, Michael van Ouwerkerk, jsbell+idb_chromium.org, alecflett+watch_chromium.org, michaeln, plundblad+watch_chromium.org, serviceworker-reviews, yurys, kinuko+serviceworker, cmumford, horo+watch_chromium.org, kinuko+fileapi, pfeldman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixes for re-enabling more MSVC level 4 warnings: content/browser/ edition This contains fixes for the following sorts of issues: * Signedness mismatch * Assignment inside conditional * Possibly-uninitialized local variable This also contains a very small number of other cleanups to nearby code. BUG=81439 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283169

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -32 lines)			Patch
M	content/browser/accessibility/browser_accessibility_win_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/appcache/appcache.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/browser/appcache/view_appcache_internals_job.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/browser/devtools/renderer_overrides_handler.cc	View	3 chunks	+4 lines, -5 lines	0 comments	Download
M	content/browser/fileapi/blob_url_request_job_unittest.cc	View	5 chunks	+7 lines, -6 lines	0 comments	Download
M	content/browser/frame_host/navigation_controller_impl.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/geolocation/network_location_request.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/browser/indexed_db/indexed_db_leveldb_coding.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc	View	4 chunks	+6 lines, -4 lines	0 comments	Download
M	content/browser/renderer_host/p2p/socket_host.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	content/browser/service_worker/service_worker_internals_ui.cc	View	3 chunks	+6 lines, -7 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

Scott, can you review this? John seems to be unresponsive (maybe away).

6 years, 5 months ago (2014-07-14 20:48:40 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkasting@chromium.org/373873002/1

6 years, 5 months ago (2014-07-14 22:12:09 UTC) #6

Message was sent while issue was closed.

Change committed as 283169

Expand Messages | Collapse Messages