Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: content/browser/devtools/renderer_overrides_handler.cc

Issue 373873002: Fixes for re-enabling more MSVC level 4 warnings: content/browser/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/renderer_overrides_handler.cc
diff --git a/content/browser/devtools/renderer_overrides_handler.cc b/content/browser/devtools/renderer_overrides_handler.cc
index 1bc256f9f46d0726249f5306cfa059bcb8980673..4ca8a9a65a0d53224ca61569873e6bf16dbdce36 100644
--- a/content/browser/devtools/renderer_overrides_handler.cc
+++ b/content/browser/devtools/renderer_overrides_handler.cc
@@ -326,7 +326,7 @@ RendererOverridesHandler::PageHandleJavaScriptDialog(
base::DictionaryValue* params = command->params();
const char* paramAccept =
devtools::Page::handleJavaScriptDialog::kParamAccept;
- bool accept;
+ bool accept = false;
if (!params || !params->GetBoolean(paramAccept, &accept))
return command->InvalidParamResponse(paramAccept);
base::string16 prompt_override;
@@ -433,10 +433,9 @@ RendererOverridesHandler::PageGetNavigationHistory(
scoped_refptr<DevToolsProtocol::Response>
RendererOverridesHandler::PageNavigateToHistoryEntry(
scoped_refptr<DevToolsProtocol::Command> command) {
- int entry_id;
-
base::DictionaryValue* params = command->params();
const char* param = devtools::Page::navigateToHistoryEntry::kParamEntryId;
+ int entry_id = 0;
if (!params || !params->GetInteger(param, &entry_id)) {
return command->InvalidParamResponse(param);
}
@@ -980,8 +979,8 @@ RendererOverridesHandler::InputDispatchGestureEvent(
event.globalY = event.y;
if (type == "scrollUpdate") {
- int dx;
- int dy;
+ int dx = 0;
+ int dy = 0;
if (!params->GetInteger(
devtools::Input::dispatchGestureEvent::kParamDeltaX, &dx) ||
!params->GetInteger(
« no previous file with comments | « content/browser/appcache/view_appcache_internals_job.cc ('k') | content/browser/fileapi/blob_url_request_job_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698