content/browser/geolocation/network_location_request.cc - Issue 373873002: Fixes for re-enabling more MSVC level 4 warnings: content/browser/ edition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/geolocation/network_location_request.cc

Issue 373873002: Fixes for re-enabling more MSVC level 4 warnings: content/browser/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/navigation_controller_impl.cc ('k') | content/browser/indexed_db/indexed_db_leveldb_coding.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/geolocation/network_location_request.cc

diff --git a/content/browser/geolocation/network_location_request.cc b/content/browser/geolocation/network_location_request.cc

index 8fb6e6a907621b9382f7828b031a9886ed6fdb40..75c7c8434f4d281112cff9d9bf4804ff0f2d5436 100644

--- a/content/browser/geolocation/network_location_request.cc

+++ b/content/browser/geolocation/network_location_request.cc

@@ -409,7 +409,8 @@ bool ParseServerResponse(const std::string& response_body,

static_cast<const base::DictionaryValue*>(location_value);

// latitude and longitude fields are always required.

- double latitude, longitude;

+ double latitude = 0;

+ double longitude = 0;

if (!GetAsDouble(*location_object, kLatitudeString, &latitude) ||

!GetAsDouble(*location_object, kLongitudeString, &longitude)) {

VLOG(1) << "ParseServerResponse() : location lacks lat and/or long.";