ios fixes

ios fixes

skia_ios.mm
Get the app's Documents directory and pass use it to set the resource path.
This is a quick hack which will be replaced by a new application that is
a tiny shim around a command line tool.

SkImageEncoder.h
SkForceLinking.cpp
SkImageDecoder_CG.cpp
Add support for FORCE_LINKING so iOS sees the PNG encoder and others.

SkFloatBits.cpp
SkPoint.cpp
Handle denormalized numbers that are floored by the iOS ARM processor.

SkImageDecoder_iOS.mm
Remove empty encoder factory.

SkTouchGesture.cpp
Return early on empty state on touch rather than aborting (crashing)

JpegTest.cpp
Hal via stackoverflow.com says partial jpegs can be gray as well.

skia_test.cpp
Remove crash handler call for now to avoid link failure.

OverwriteLine.h
Remove fancy line overwrite for iOS.

Resources.cpp
Add interface to set resource directory based on runtime query.


BUG=skia:2736
skia:2737 skia:2738

Committed: https://skia.googlesource.com/skia/+/936b73424f7393994be832376287da988a52b993

[reed1, 2014-07-10 18:39:39]

https://codereview.chromium.org/373383003/diff/20001/src/core/SkFloatBits.cpp
File src/core/SkFloatBits.cpp (right):

https://codereview.chromium.org/373383003/diff/20001/src/core/SkFloatBits.cpp...
src/core/SkFloatBits.cpp:89: if (exp > 149) return 0;
Can we perhaps encapsulate this in a helper function, like handle_underflow.
Then we could #ifdef and adda  comment with a bug or test reference to help
explain why.

https://codereview.chromium.org/373383003/diff/20001/src/core/SkPoint.cpp
File src/core/SkPoint.cpp (right):

https://codereview.chromium.org/373383003/diff/20001/src/core/SkPoint.cpp#new...
src/core/SkPoint.cpp:172: double dscale = length / sqrt(xx * xx + yy * yy);
Can we add a comment and/or bug/test ref to explain why we need this?

I wonder if we want a new flag (not necessarily iOS specific) that triggers
this? e.g. SK_FAST_UNDERFLOW_BEHAVIOR? Just a though, which might also help
document what's going on.

https://codereview.chromium.org/373383003/diff/20001/tests/skia_test.cpp
File tests/skia_test.cpp (right):

https://codereview.chromium.org/373383003/diff/20001/tests/skia_test.cpp#newc...
tests/skia_test.cpp:137: SetupCrashHandler();
Comment why we're skipping this? Perhaps a bug or todo in case we are smarter in
the future, or iOS changes?

[caryclark, 2014-07-10 21:07:03]

https://codereview.chromium.org/373383003/diff/20001/src/core/SkFloatBits.cpp
File src/core/SkFloatBits.cpp (right):

https://codereview.chromium.org/373383003/diff/20001/src/core/SkFloatBits.cpp...
src/core/SkFloatBits.cpp:89: if (exp > 149) return 0;
On 2014/07/10 18:39:39, reed1 wrote:
> Can we perhaps encapsulate this in a helper function, like handle_underflow.
> Then we could #ifdef and adda  comment with a bug or test reference to help
> explain why.

I commented and gave it a platform independent #define, but it's unclear to me
how to isolate this in a helper function.

https://codereview.chromium.org/373383003/diff/20001/src/core/SkPoint.cpp
File src/core/SkPoint.cpp (right):

https://codereview.chromium.org/373383003/diff/20001/src/core/SkPoint.cpp#new...
src/core/SkPoint.cpp:172: double dscale = length / sqrt(xx * xx + yy * yy);
On 2014/07/10 18:39:39, reed1 wrote:
> Can we add a comment and/or bug/test ref to explain why we need this?
> 
> I wonder if we want a new flag (not necessarily iOS specific) that triggers
> this? e.g. SK_FAST_UNDERFLOW_BEHAVIOR? Just a though, which might also help
> document what's going on.

Done.

https://codereview.chromium.org/373383003/diff/20001/tests/skia_test.cpp
File tests/skia_test.cpp (right):

https://codereview.chromium.org/373383003/diff/20001/tests/skia_test.cpp#newc...
tests/skia_test.cpp:137: SetupCrashHandler();
On 2014/07/10 18:39:39, reed1 wrote:
> Comment why we're skipping this? Perhaps a bug or todo in case we are smarter
in
> the future, or iOS changes?

Done.

[caryclark, 2014-07-10 21:09:12]

This rev of the CL adds a new gyp specific to iOS. Before, it hacked up
SampleApp to run unit tests.

[reed1, 2014-07-10 21:40:05]

api lgtm

https://codereview.chromium.org/373383003/diff/30001/src/core/SkFloatBits.cpp
File src/core/SkFloatBits.cpp (right):

https://codereview.chromium.org/373383003/diff/30001/src/core/SkFloatBits.cpp...
src/core/SkFloatBits.cpp:92: if (exp > 149) return 0;
nit: {} and indentation

if (exp > 149) {
    return 0;
}

https://codereview.chromium.org/373383003/diff/30001/src/core/SkPoint.cpp
File src/core/SkPoint.cpp (right):

https://codereview.chromium.org/373383003/diff/30001/src/core/SkPoint.cpp#new...
src/core/SkPoint.cpp:172: // The iOS ARM processor discards small denormalized
numbers to go faster.
I think this comment belongs in SkMathPriv.h or whereever we define this symbol.

That said, I know you took my suggested name, but seeing it now I'm not sure its
a good encapsulation of the behavior/difference, but I'll leave that to you.

[tfarina, 2014-07-11 00:59:25]

https://codereview.chromium.org/373383003/diff/30001/tools/Resources.h
File tools/Resources.h (right):

https://codereview.chromium.org/373383003/diff/30001/tools/Resources.h#newcode14
tools/Resources.h:14: void SetResourcePath(const char* );
where do you use this new function?

[caryclark, 2014-07-11 12:57:20]

https://codereview.chromium.org/373383003/diff/30001/src/core/SkFloatBits.cpp
File src/core/SkFloatBits.cpp (right):

https://codereview.chromium.org/373383003/diff/30001/src/core/SkFloatBits.cpp...
src/core/SkFloatBits.cpp:92: if (exp > 149) return 0;
On 2014/07/10 21:40:05, reed1 wrote:
> nit: {} and indentation
> 
> if (exp > 149) {
>     return 0;
> }

Done.

https://codereview.chromium.org/373383003/diff/30001/src/core/SkPoint.cpp
File src/core/SkPoint.cpp (right):

https://codereview.chromium.org/373383003/diff/30001/src/core/SkPoint.cpp#new...
src/core/SkPoint.cpp:172: // The iOS ARM processor discards small denormalized
numbers to go faster.
On 2014/07/10 21:40:05, reed1 wrote:
> I think this comment belongs in SkMathPriv.h or whereever we define this
symbol.
> 
> That said, I know you took my suggested name, but seeing it now I'm not sure
its
> a good encapsulation of the behavior/difference, but I'll leave that to you.

Done.

https://codereview.chromium.org/373383003/diff/30001/tools/Resources.h
File tools/Resources.h (right):

https://codereview.chromium.org/373383003/diff/30001/tools/Resources.h#newcode14
tools/Resources.h:14: void SetResourcePath(const char* );
On 2014/07/11 00:59:25, tfarina wrote:
> where do you use this new function?

iOSShell.cpp line 61

[caryclark, 2014-07-11 18:43:11]

The CQ bit was checked by caryclark@google.com

[commit-bot: I haz the power, 2014-07-11 18:43:33]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/caryclark@google.com/373383003/90001

[commit-bot: I haz the power, 2014-07-11 19:14:55]

Change committed as 936b73424f7393994be832376287da988a52b993