Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Unified Diff: chrome/browser/prefs/command_line_pref_store.cc

Issue 372103006: Stamp out CreateStringValue in chrome/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/command_line_pref_store.cc
diff --git a/chrome/browser/prefs/command_line_pref_store.cc b/chrome/browser/prefs/command_line_pref_store.cc
index 2bb0498f62bb91b8a08c62749e213201a7620217..2cb883f9469fdb8a96e644cd38020475df5fc8f8 100644
--- a/chrome/browser/prefs/command_line_pref_store.cc
+++ b/chrome/browser/prefs/command_line_pref_store.cc
@@ -98,9 +98,9 @@ void CommandLinePrefStore::ApplySimpleSwitches() {
// Look for each switch we know about and set its preference accordingly.
for (size_t i = 0; i < arraysize(string_switch_map_); ++i) {
if (command_line_->HasSwitch(string_switch_map_[i].switch_name)) {
- base::Value* value = base::Value::CreateStringValue(command_line_->
- GetSwitchValueASCII(string_switch_map_[i].switch_name));
- SetValue(string_switch_map_[i].preference_path, value);
+ SetValue(string_switch_map_[i].preference_path,
+ new base::StringValue(command_line_->GetSwitchValueASCII(
+ string_switch_map_[i].switch_name)));
}
}
@@ -161,7 +161,7 @@ void CommandLinePrefStore::ApplySSLSwitches() {
base::ListValue* list_value = new base::ListValue();
for (std::vector<std::string>::const_iterator it = cipher_strings.begin();
it != cipher_strings.end(); ++it) {
- list_value->Append(base::Value::CreateStringValue(*it));
+ list_value->Append(new base::StringValue(*it));
}
SetValue(prefs::kCipherSuiteBlacklist, list_value);
}

Powered by Google App Engine
This is Rietveld 408576698