Fixes for re-enabling more MSVC level 4 warnings: courgette/ edition

Fixes for re-enabling more MSVC level 4 warnings: courgette/ edition

This contains fixes for the following sorts of issues:
* Signedness mismatch

BUG=81439
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281696

[tommi (sloooow) - chröme, 2014-07-08 07:56:15]

lgtm

https://codereview.chromium.org/371153002/diff/1/courgette/encoded_program.cc
File courgette/encoded_program.cc (right):

https://codereview.chromium.org/371153002/diff/1/courgette/encoded_program.cc...
courgette/encoded_program.cc:713: pod.page_rva = 0xFFFFFFFF;
I'm curious - does this actually make a difference?

[commit-bot: I haz the power, 2014-07-08 07:57:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pkasting@chromium.org/371153002/1

[commit-bot: I haz the power, 2014-07-08 08:41:00]

Change committed as 281696

[Peter Kasting, 2014-07-08 19:33:47]

https://codereview.chromium.org/371153002/diff/1/courgette/encoded_program.cc
File courgette/encoded_program.cc (right):

https://codereview.chromium.org/371153002/diff/1/courgette/encoded_program.cc...
courgette/encoded_program.cc:713: pod.page_rva = 0xFFFFFFFF;
On 2014/07/08 07:56:15, tommi wrote:
> I'm curious - does this actually make a difference?

~0 is signed (I believe because 0 is signed), while 0xFFFFFFFF is not.

[tommi (sloooow) - chröme, 2014-07-08 19:37:00]

ah, of course. Thanks.


On Tue, Jul 8, 2014 at 9:33 PM, <pkasting@chromium.org> wrote:

>
> https://codereview.chromium.org/371153002/diff/1/
> courgette/encoded_program.cc
> File courgette/encoded_program.cc (right):
>
> https://codereview.chromium.org/371153002/diff/1/
> courgette/encoded_program.cc#newcode713
> courgette/encoded_program.cc:713: pod.page_rva = 0xFFFFFFFF;
> On 2014/07/08 07:56:15, tommi wrote:
>
>> I'm curious - does this actually make a difference?
>>
>
> ~0 is signed (I believe because 0 is signed), while 0xFFFFFFFF is not.
>
> https://codereview.chromium.org/371153002/
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.