courgette/encoded_program.cc - Issue 371153002: Fixes for re-enabling more MSVC level 4 warnings: courgette/ edition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: courgette/encoded_program.cc

Issue 371153002: Fixes for re-enabling more MSVC level 4 warnings: courgette/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: courgette/encoded_program.cc

diff --git a/courgette/encoded_program.cc b/courgette/encoded_program.cc

index 8fb8c6952448a1d6d6fb03dc509061cf11e0b5ce..b78e7fef93cc9092c81e38c0d1d9af94dc7fac15 100644

--- a/courgette/encoded_program.cc

+++ b/courgette/encoded_program.cc

@@ -710,7 +710,7 @@ COMPILE_ASSERT(offsetof(RelocBlockPOD, relocs) == 8, reloc_block_header_size);

class RelocBlock {

public:

RelocBlock() {

- pod.page_rva = ~0;

+ pod.page_rva = 0xFFFFFFFF;

tommi (sloooow) - chröme 2014/07/08 07:56:15 I'm curious - does this actually make a difference

Peter Kasting 2014/07/08 19:33:47 ~0 is signed (I believe because 0 is signed), whil

pod.block_size = 8;

}

« no previous file with comments | « courgette/disassembler_elf_32_arm.cc ('k') | no next file » | no next file with comments »