Fixes for re-enabling more MSVC level 4 warnings: courgette/ edition

courgette/encoded_program.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "courgette/encoded_program.h"
 
 #include <algorithm>
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 692 matching lines @@
   uint32 page_rva;
   uint32 block_size;
   uint16 relocs[4096];  // Allow up to one relocation per byte of a 4k page.
 };
 
 COMPILE_ASSERT(offsetof(RelocBlockPOD, relocs) == 8, reloc_block_header_size);
 
 class RelocBlock {
  public:
   RelocBlock() {
-    pod.page_rva = ~0;
+    pod.page_rva = 0xFFFFFFFF;

[tommi (sloooow) - chröme, 2014/07/08 07:56:15]

I'm curious - does this actually make a difference?

[Peter Kasting, 2014/07/08 19:33:47]

~0 is signed (I believe because 0 is signed), while 0xFFFFFFFF is not.

     pod.block_size = 8;
   }
 
   void Add(uint16 item) {
     pod.relocs[(pod.block_size-8)/2] = item;
     pod.block_size += 2;
   }
 
   CheckBool Flush(SinkStream* buffer) WARN_UNUSED_RESULT {
     bool ok = true;
@@ skipping 69 matching lines @@
   if (assembled)
     return C_OK;
   return C_ASSEMBLY_FAILED;
 }
 
 void DeleteEncodedProgram(EncodedProgram* encoded) {
   delete encoded;
 }
 
 }  // end namespace