content/common/frame_messages.h - Issue 368953006: Added the RenderView routing_id to the DidCommitProvisionalLoad message.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/frame_messages.h

Issue 368953006: Added the RenderView routing_id to the DidCommitProvisionalLoad message. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added comments referencing the RenderView dependencies bug Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/loader/resource_scheduler_filter.cc ('K') | « content/browser/loader/resource_scheduler_filter.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | content/renderer/render_frame_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/frame_messages.h

diff --git a/content/common/frame_messages.h b/content/common/frame_messages.h

index 1b83f26eabab76e1695a9dc870a8f7a2f260aae0..07f6b11325136c2205dde09a62089a166adb85d1 100644

--- a/content/common/frame_messages.h

+++ b/content/common/frame_messages.h

@@ -151,6 +151,15 @@ IPC_STRUCT_BEGIN_WITH_PARENT(FrameHostMsg_DidCommitProvisionalLoad_Params,

// Notifies the browser that for this navigation, the session history was

// successfully cleared.

IPC_STRUCT_MEMBER(bool, history_list_was_cleared)

+ // The routing_id of the render view associated with the navigation.

+ // We need to track the RenderViewHost routing_id because of downstream

+ // dependencies on being able to look up the view based on the ID stored

+ // in the resource requests (without it a lot of things break). Once

+ // those dependencies are unwound or moved to RenderViewHost we can move

nasko 2014/07/21 13:11:23 Did you mean RenderFrameHost here and the line bel

+ // the client to be based on the routing_id of the RenderViewHost

+ // instead (see crbug.com/392171).

+ IPC_STRUCT_MEMBER(int, render_view_routing_id)

IPC_STRUCT_END()

IPC_STRUCT_BEGIN(FrameMsg_Navigate_Params)