Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Side by Side Diff: content/common/frame_messages.h

Issue 368953006: Added the RenderView routing_id to the DidCommitProvisionalLoad message. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added comments referencing the RenderView dependencies bug Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // IPC messages for interacting with frames. 5 // IPC messages for interacting with frames.
6 // Multiply-included message file, hence no include guard. 6 // Multiply-included message file, hence no include guard.
7 7
8 #include "content/common/content_export.h" 8 #include "content/common/content_export.h"
9 #include "content/common/content_param_traits.h" 9 #include "content/common/content_param_traits.h"
10 #include "content/common/frame_message_enums.h" 10 #include "content/common/frame_message_enums.h"
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 144
145 // Original request's URL. 145 // Original request's URL.
146 IPC_STRUCT_MEMBER(GURL, original_request_url) 146 IPC_STRUCT_MEMBER(GURL, original_request_url)
147 147
148 // User agent override used to navigate. 148 // User agent override used to navigate.
149 IPC_STRUCT_MEMBER(bool, is_overriding_user_agent) 149 IPC_STRUCT_MEMBER(bool, is_overriding_user_agent)
150 150
151 // Notifies the browser that for this navigation, the session history was 151 // Notifies the browser that for this navigation, the session history was
152 // successfully cleared. 152 // successfully cleared.
153 IPC_STRUCT_MEMBER(bool, history_list_was_cleared) 153 IPC_STRUCT_MEMBER(bool, history_list_was_cleared)
154
155 // The routing_id of the render view associated with the navigation.
156 // We need to track the RenderViewHost routing_id because of downstream
157 // dependencies on being able to look up the view based on the ID stored
158 // in the resource requests (without it a lot of things break). Once
159 // those dependencies are unwound or moved to RenderViewHost we can move
nasko 2014/07/21 13:11:23 Did you mean RenderFrameHost here and the line bel
160 // the client to be based on the routing_id of the RenderViewHost
161 // instead (see crbug.com/392171).
162 IPC_STRUCT_MEMBER(int, render_view_routing_id)
154 IPC_STRUCT_END() 163 IPC_STRUCT_END()
155 164
156 IPC_STRUCT_BEGIN(FrameMsg_Navigate_Params) 165 IPC_STRUCT_BEGIN(FrameMsg_Navigate_Params)
157 // The page_id for this navigation, or -1 if it is a new navigation. Back, 166 // The page_id for this navigation, or -1 if it is a new navigation. Back,
158 // Forward, and Reload navigations should have a valid page_id. If the load 167 // Forward, and Reload navigations should have a valid page_id. If the load
159 // succeeds, then this page_id will be reflected in the resultant 168 // succeeds, then this page_id will be reflected in the resultant
160 // FrameHostMsg_DidCommitProvisionalLoad message. 169 // FrameHostMsg_DidCommitProvisionalLoad message.
161 IPC_STRUCT_MEMBER(int32, page_id) 170 IPC_STRUCT_MEMBER(int32, page_id)
162 171
163 // If page_id is -1, then pending_history_list_offset will also be -1. 172 // If page_id is -1, then pending_history_list_offset will also be -1.
(...skipping 444 matching lines...) Expand 10 before | Expand all | Expand 10 after
608 // |endOffset| are the offsets of the selection in the returned |content|. 617 // |endOffset| are the offsets of the selection in the returned |content|.
609 IPC_MESSAGE_ROUTED3(FrameHostMsg_TextSurroundingSelectionResponse, 618 IPC_MESSAGE_ROUTED3(FrameHostMsg_TextSurroundingSelectionResponse,
610 base::string16, /* content */ 619 base::string16, /* content */
611 size_t, /* startOffset */ 620 size_t, /* startOffset */
612 size_t /* endOffset */) 621 size_t /* endOffset */)
613 622
614 // Notifies the browser that the renderer has a pending navigation transition. 623 // Notifies the browser that the renderer has a pending navigation transition.
615 IPC_MESSAGE_CONTROL2(FrameHostMsg_SetHasPendingTransitionRequest, 624 IPC_MESSAGE_CONTROL2(FrameHostMsg_SetHasPendingTransitionRequest,
616 int /* render_frame_id */, 625 int /* render_frame_id */,
617 bool /* is_transition */) 626 bool /* is_transition */)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698