Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2703)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 368953006: Added the RenderView routing_id to the DidCommitProvisionalLoad message. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added comments referencing the RenderView dependencies bug Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/common/frame_messages.h ('K') | « content/common/frame_messages.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 6ccb9f5995949069dbeadc97faa76fd507a3ac9b..cacc6299e0798975be287ae9a14fa754a7ebbe74 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -2954,6 +2954,13 @@ void RenderFrameImpl::UpdateURL(blink::WebFrame* frame) {
params.is_post = false;
params.post_id = -1;
params.page_id = render_view_->page_id_;
+ // We need to track the RenderViewHost routing_id because of downstream
+ // dependencies on being able to look up the view based on the ID stored
+ // in the resource requests (without it a lot of things break). Once
+ // those dependencies are unwound or moved to RenderViewHost we can move
nasko 2014/07/21 13:11:23 Same as other comment.
+ // the client to be based on the routing_id of the RenderViewHost
+ // instead (see crbug.com/392171).
+ params.render_view_routing_id = render_view_->routing_id();
params.socket_address.set_host(response.remoteIPAddress().utf8());
params.socket_address.set_port(response.remotePort());
WebURLResponseExtraDataImpl* extra_data = GetExtraDataFromResponse(response);
« content/common/frame_messages.h ('K') | « content/common/frame_messages.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698