Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1259)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 36843003: Improve remaining TypeErrors in bindings code. (Closed)

Created:
7 years, 2 months ago by Mike West
Modified:
7 years, 1 month ago
CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive
Visibility:
Public.

Description

Improve remaining TypeErrors in bindings code. BUG=270033 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162223

Patch Set 1 #

Patch Set 2 : Tests. #

Patch Set 3 : NeedsRebaseline for pixel test. #

Patch Set 4 : Rebase. #

Patch Set 5 : vibration. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -90 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/canvas/philip/tests/2d.pattern.image.string-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/canvas/philip/tests/2d.pattern.image.undefined-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-createImageBitmap-invalid-args.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-createImageBitmap-invalid-args-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-currentTransform-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-overloads-drawImage-expected.txt View 1 1 chunk +12 lines, -12 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-overloads-setFillColor-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-overloads-setShadow-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-overloads-setStrokeColor-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-putImageData.js View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-putImageData-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/script-tests/canvas-currentTransform.js View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/script-tests/canvas-overloads-drawImage.js View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/script-tests/canvas-overloads-fillText.js View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/canvas/script-tests/canvas-overloads-setFillColor.js View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/script-tests/canvas-overloads-setShadow.js View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/script-tests/canvas-overloads-setStrokeColor.js View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/webgl/texImageTest-expected.txt View 1 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/events/drag-dataTransferItemList.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/drag-dataTransferItemList-expected.txt View 1 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/js/select-options-remove-expected.txt View 1 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/mediastream/MediaStreamConstructor-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/mediastream/RTCPeerConnection-ice-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/svg/dynamic-updates/script-tests/SVGMarkerElement-svgdom-setOrientToAngle-call.js View 1 chunk +6 lines, -5 lines 0 comments Download
M LayoutTests/svg/text/svgtextcontentelement-methods-parameters.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/text/svgtextcontentelement-methods-parameters-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/vibration/vibration-exceptions-expected.txt View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/scripts/code_generator_v8.pm View 1 2 3 7 chunks +9 lines, -5 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 1 2 3 12 chunks +11 lines, -12 lines 0 comments Download
M Source/bindings/tests/results/V8TestObjectPython.cpp View 1 2 3 10 chunks +10 lines, -10 lines 0 comments Download
M Source/bindings/tests/results/V8TestOverloadedConstructors.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Mike West
Mind taking a look at this error message improvement? -mike
7 years, 2 months ago (2013-10-23 09:56:04 UTC) #1
jochen (gone - plz use gerrit)
the bots seem to be unhappy?
7 years, 1 month ago (2013-10-23 13:23:57 UTC) #2
Use mkwst_at_chromium.org plz.
On 2013/10/23 13:23:57, jochen wrote: > the bots seem to be unhappy? Bots are _always_ ...
7 years, 1 month ago (2013-10-23 13:25:33 UTC) #3
Mike West
Mind taking another look? I think the bots will be happier.
7 years, 1 month ago (2013-10-24 07:56:35 UTC) #4
jochen (gone - plz use gerrit)
actually, they're really sad now but lgtm anyway
7 years, 1 month ago (2013-10-24 12:24:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/36843003/170001
7 years, 1 month ago (2013-11-18 09:39:24 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=12884
7 years, 1 month ago (2013-11-18 10:47:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/36843003/340001
7 years, 1 month ago (2013-11-18 13:27:58 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=17711
7 years, 1 month ago (2013-11-18 15:26:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/36843003/340001
7 years, 1 month ago (2013-11-18 17:01:10 UTC) #10
commit-bot: I haz the power
Change committed as 162223
7 years, 1 month ago (2013-11-18 19:22:09 UTC) #11
Nils Barth (inactive)
7 years, 1 month ago (2013-11-19 01:39:27 UTC) #12
Message was sent while issue was closed. 
For the record, Python side change is:
IDL compiler: Sync Python to r162223
https://codereview.chromium.org/71203007/

Powered by Google App Engine
This is Rietveld 408576698