Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Side by Side Diff: Source/bindings/tests/results/V8TestOverloadedConstructors.cpp

Issue 36843003: Improve remaining TypeErrors in bindings code. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: vibration. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/bindings/tests/results/V8TestObjectPython.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 return; 136 return;
137 } 137 }
138 if (((info.Length() == 1))) { 138 if (((info.Length() == 1))) {
139 TestOverloadedConstructorsV8Internal::constructor4(info); 139 TestOverloadedConstructorsV8Internal::constructor4(info);
140 return; 140 return;
141 } 141 }
142 if (UNLIKELY(info.Length() < 1)) { 142 if (UNLIKELY(info.Length() < 1)) {
143 throwTypeError(ExceptionMessages::failedToConstruct("TestOverloadedConst ructors", ExceptionMessages::notEnoughArguments(1, info.Length())), info.GetIsol ate()); 143 throwTypeError(ExceptionMessages::failedToConstruct("TestOverloadedConst ructors", ExceptionMessages::notEnoughArguments(1, info.Length())), info.GetIsol ate());
144 return; 144 return;
145 } 145 }
146 throwUninformativeAndGenericTypeError(info.GetIsolate()); 146 throwTypeError(ExceptionMessages::failedToConstruct("TestOverloadedConstruct ors", "No matching constructor signature."), info.GetIsolate());
147 return; 147 return;
148 } 148 }
149 149
150 } // namespace TestOverloadedConstructorsV8Internal 150 } // namespace TestOverloadedConstructorsV8Internal
151 151
152 void V8TestOverloadedConstructors::constructorCallback(const v8::FunctionCallbac kInfo<v8::Value>& info) 152 void V8TestOverloadedConstructors::constructorCallback(const v8::FunctionCallbac kInfo<v8::Value>& info)
153 { 153 {
154 TRACE_EVENT_SCOPED_SAMPLING_STATE("Blink", "DOMConstructor"); 154 TRACE_EVENT_SCOPED_SAMPLING_STATE("Blink", "DOMConstructor");
155 if (!info.IsConstructCall()) { 155 if (!info.IsConstructCall()) {
156 throwTypeError(ExceptionMessages::failedToConstruct("TestOverloadedConst ructors", "Please use the 'new' operator, this DOM object constructor cannot be called as a function."), info.GetIsolate()); 156 throwTypeError(ExceptionMessages::failedToConstruct("TestOverloadedConst ructors", "Please use the 'new' operator, this DOM object constructor cannot be called as a function."), info.GetIsolate());
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
234 V8DOMWrapper::associateObjectWithWrapper<V8TestOverloadedConstructors>(impl, &wrapperTypeInfo, wrapper, isolate, WrapperConfiguration::Independent); 234 V8DOMWrapper::associateObjectWithWrapper<V8TestOverloadedConstructors>(impl, &wrapperTypeInfo, wrapper, isolate, WrapperConfiguration::Independent);
235 return wrapper; 235 return wrapper;
236 } 236 }
237 237
238 void V8TestOverloadedConstructors::derefObject(void* object) 238 void V8TestOverloadedConstructors::derefObject(void* object)
239 { 239 {
240 fromInternalPointer(object)->deref(); 240 fromInternalPointer(object)->deref();
241 } 241 }
242 242
243 } // namespace WebCore 243 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/tests/results/V8TestObjectPython.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698